Init and minio #1662
Init and minio #1662
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1662 +/- ##
==========================================
- Coverage 77.89% 77.88% -0.02%
==========================================
Files 234 232 -2
Lines 18183 18143 -40
==========================================
- Hits 14163 14130 -33
+ Misses 4020 4013 -7
Continue to review full report at Codecov.
|
cosmos-traefik/Dockerfile-dev
Outdated
| @@ -1,3 +1,8 @@ | |||
| FROM traefik:2.4.13 | |||
| FROM traefik:2.6.6 | |||
There was a problem hiding this comment.
Change to 2.7.0 to match Dockerfile
cosmos-traefik/Dockerfile-dev-base
Outdated
| @@ -1,3 +1,8 @@ | |||
| FROM traefik:2.4.13 | |||
| FROM traefik:2.6.6 | |||
There was a problem hiding this comment.
Change to 2.7.0 to match Dockerfile
| @@ -0,0 +1,99 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Where did this file come from?
There was a problem hiding this comment.
This is a file you can optionally use in the traefik config to allow regular http
| # - "${PWD}/cosmos-traefik/traefik-ssl.yaml:/etc/traefik/traefik.yaml" | ||
| # - "${PWD}/cosmos-traefik/traefik-letsencrypt.yaml:/etc/traefik/traefik.yaml" | ||
| # - "${PWD}/cosmos-traefik/cert.key:/etc/traefik/cert.key" | ||
| # - "${PWD}/cosmos-traefik/cert.crt:/etc/traefik/cert.crt" |
There was a problem hiding this comment.
Are these just commented out examples for future users?
There was a problem hiding this comment.
Yes, I'll be writing directions in cosmosc2-project to use each of these.
.github/workflows/playwright.yml
Outdated
| uses: github/codeql-action/upload-sarif@v2 | ||
| with: | ||
| sarif_file: results.sarif | ||
| category: traefik |
There was a problem hiding this comment.
Merge master and get all my new container scan logic. I use a matrix to avoid duplication.
There was a problem hiding this comment.
The way you did it doesn't work unfortunately. Each "job" is a seperate virtual machine, so the local Docker images aren't available from the cosmos-build job to the playwright and scan jobs. It was always just using the "latest" from Docker Hub. Had to combine into one job.
| SSL_CERT_FILE: "/devel/cacert.pem" | ||
| CURL_CA_BUNDLE: "/devel/cacert.pem" | ||
| REQUESTS_CA_BUNDLE: "/devel/cacert.pem" | ||
| NODE_EXTRA_CA_CERTS: "/devel/cacert.pem" |
There was a problem hiding this comment.
Why all the new CERT lines?
There was a problem hiding this comment.
These make local SSL configurations work in each container if you just volume mount in the correct cacert.pem file.
Merge init containers and make minio into its own versioned container