Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor binary_accessor #72

Closed
jmthomas opened this issue Feb 20, 2015 · 5 comments
Closed

Refactor binary_accessor #72

jmthomas opened this issue Feb 20, 2015 · 5 comments
Assignees
@jmthomas
Labels
maintenance
Milestone
v3.4.0

Comments

@jmthomas
Copy link
Contributor

BinaryAccessor has been on my todo for a while. It always shows up with tons of duplication and complexity.
@ghost
Copy link

ghost commented Feb 20, 2015

You're just going to rewrite the whole thing in C right? ;)

@jmthomas
Copy link
Contributor Author

Were you still planning on making this a separate gem?

@ghost
Copy link

ghost commented Feb 20, 2015

I licensed binary_accessor/structure and json_drb differently with the end goal of making them seperate LGPL gems.

@jmthomas
Copy link
Contributor Author

Might be a chance to brush up on my C extension skills. I'll take a crack at it.

@jmthomas
Copy link
Contributor Author

I don't know that I should prematurely optimize this into a C extension if you want to make it more widely available. Making it a C extension prevents Rubinious and JRuby users from using it. Although we've already been forced to a partial C extension due to performance.

jmthomas added a commit that referenced this issue Apr 3, 2015
@jmthomas
Implement BinaryAccessor write as C extension #72
56b52c5
jmthomas added a commit that referenced this issue Apr 3, 2015
@jmthomas
Refactor and add benchmarking #72
2917aa5
jmthomas added a commit that referenced this issue Apr 3, 2015
@jmthomas
Add benchmark-ips to gemspec #72
6d9447d
jmthomas added a commit that referenced this issue Apr 3, 2015
@jmthomas
Update spec to capture current behavior #72
154c02d
jmthomas added a commit that referenced this issue Apr 6, 2015
@jmthomas
Cast value for INT and FLOAT. Capture additional behavior in spec and…
39513f1 
… fix bug #72
jmthomas added a commit that referenced this issue Apr 8, 2015
@jmthomas
Update spec and helper to test vs changes in refactor_binary_accessor…
4360ba8 
… branch #72
jmthomas added a commit that referenced this issue Apr 8, 2015
@jmthomas
Revert "Update spec and helper to test vs changes in refactor_binary_…
da851e3 
…accessor branch #72"

This reverts commit 4360ba8.
@jmthomas jmthomas self-assigned this Apr 10, 2015
jmthomas added a commit that referenced this issue Apr 20, 2015
@jmthomas
Implement BinaryAccessor write as C extension #72
d604cff
jmthomas added a commit that referenced this issue Apr 20, 2015
@jmthomas
Refactor and add benchmarking #72
50dc7cd
jmthomas added a commit that referenced this issue Apr 20, 2015
@jmthomas
Add benchmark-ips to gemspec #72
d5c5a0d
jmthomas added a commit that referenced this issue Apr 20, 2015
@jmthomas
Update spec to capture current behavior #72
f978c42
jmthomas added a commit that referenced this issue Apr 20, 2015
@jmthomas
Cast value for INT and FLOAT. Capture additional behavior in spec and…
70917d8 
… fix bug #72
@ghost ghost modified the milestone: v3.4.0 Apr 27, 2015
ghost pushed a commit that referenced this issue Apr 7, 2021
@jmthomas
Pull request #72: Fix microservice operator spec
570c6d7 
Merge in COSMOSEE/base from rspec_fixes to master

* commit '7b9c34312e68957901c05b4c413f3ab239a930ec':
  Fix yaml spec
  Fix microservice operator spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmthomas jmthomas

Labels
maintenance
Projects
None yet
Milestone
v3.4.0
Development

No branches or pull requests
1 participant
@jmthomas