ask() should take a default #70
Comments
|
We might also want to allow message_box() to take a default for which button is selected so the user can just hit enter and select the default. That one is easier because the API is message_box(string, buttons) and default can just be added to the end. |
|
I'm ok with changing the ask API and making default the second argument. We can handle it short term, by detecting if the second parameter is a string or a boolean, and assuming which API they are using based on that. If using the old API we can output a deprecation warning and then remove it in a later release. |
|
I think that would work. I'm also going to change the behavior of the Cancel button on dialogs. If you click Cancel the script just pauses. At that point the user can click Go or Stop using the usual buttons. It saves the additional dialog which isn't really buying anything. |
|
Ok. removing the second dialog will break autohotkey so make sure you update that. |
|
Will do. |
|
Actually let's make the second parameter to ask be "default_or_allow_blank". Behavior: |
|
I think the purpose of allow_blank was to have the software inject a default if blank |
|
Sounds good. |
ghost
added
the
|
Do you want this in the release today? |
|
Sure, let me take a stab at it this morning. Worse part will probably be AHK. |
jmthomas
added a commit
that referenced
this issue
Feb 20, 2015
jmthomas
added a commit
that referenced
this issue
Feb 20, 2015
ghost
pushed a commit
that referenced
this issue
Feb 20, 2015
ghost
pushed a commit
that referenced
this issue
Apr 7, 2021
Merge in COSMOSEE/base from kebab-case-cosmos to master Squashed commit of the following: commit eb08f19239215319fc09197ffaea823784f8c61a Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 20:49:54 2021 -0600 cosmos_start commit 249ba7ba17013205177d375fcc7de9d8820471e8 Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 20:40:00 2021 -0600 remove curl test commit bf7843c9b70c3f0532bdd6ff0c73cf2484e60f4a Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 20:09:04 2021 -0600 package update commit d8a011c6814395fae033160ef531d32c6de71940 Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 16:15:42 2021 -0600 update to better logs commit f66f0392bbecd3f03c5e663202ed2fcb77558e12 Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 15:15:42 2021 -0600 kebab-case-cosmos
RubenFixit
referenced
this issue
in RubenFixit/COSMOS
Apr 23, 2021
* Update specs * Update packet_log_reader * Rename entry type mask * Remove RUBYLIB and bundle exec * Address PR feedback * Update streaming_api for new log file changes * Fix streaming api file search * Add debug and fix base Dockerfile * Revert "Remove RUBYLIB and bundle exec" This reverts commit 9485a04. * Update specs * Add RUBYLIB in cosmos-base * Clarify comment * Add dockerignores * Remove comments * Pull request #35: Add utc data extractor Merge in COSMOSEE/base from add-utc-data-extractor to master Squashed commit of the following: commit d43dce4978d61a1695972b155d39e881ad89f9f6 Author: van Andel, Gerhard <[email protected]> Date: Thu Mar 4 16:48:00 2021 -0700 Update DataExtractor.vue remove values as they are not used commit 06dfe178c4f47a5033f31541ec8660fc400b17e4 Author: van Andel, Gerhard <[email protected]> Date: Thu Mar 4 14:54:14 2021 -0700 Update DataExtractor.vue commit 8271c99560f1e45d4d75aae9b0161286dd45383e Author: van Andel, Gerhard <[email protected]> Date: Thu Mar 4 14:16:02 2021 -0700 Update DataExtractor.vue * clean up corner cases and validate utc is working commit 32a8f5ec77fdf45542a582a9a5f6b873a8b2866f Author: van Andel, Gerhard <[email protected]> Date: Wed Mar 3 17:24:48 2021 -0700 Update DataExtractor.vue Maybe this.... commit f1de3bdc43a396edad703ce52904b616f0a67544 Author: van Andel, Gerhard <[email protected]> Date: Wed Mar 3 16:47:32 2021 -0700 Update DataExtractor.vue This could be working commit bb8e0e2114797a501ea6211e76113bbfab972c59 Author: van Andel, Gerhard <[email protected]> Date: Wed Mar 3 13:13:02 2021 -0700 Revert "This is broken" This reverts commit 246af5bbfd26237f0d2a9d8ad17a0cc729382a4e. commit 246af5bbfd26237f0d2a9d8ad17a0cc729382a4e Author: van Andel, Gerhard <[email protected]> Date: Wed Mar 3 10:29:21 2021 -0700 This is broken * Pull request #36: Remove aggregator add to cmd/tlm Merge in COSMOSEE/base from remove-aggregaotr-add-to-cmd-tlm-api to master Squashed commit of the following: commit fdde94e07833d002b1e07a461fde74730d2c51e1 Author: van Andel, Gerhard <[email protected]> Date: Fri Mar 5 10:03:29 2021 -0700 Delete .dockerignore commit f459efd896f6edbb8cfcd27ec48086db3f994c3c Merge: dbba4c83 1586d46 Author: van Andel, Gerhard <[email protected]> Date: Fri Mar 5 10:03:06 2021 -0700 Merge branch 'master' of https://bitbucket.aero.ball.com/bitbucket/scm/cosmosee/base into remove-aggregaotr-add-to-cmd-tlm-api commit dbba4c8351c905fc5384ab6fa3c6a0ddffbfa7f6 Author: van Andel, Gerhard <[email protected]> Date: Fri Mar 5 10:00:26 2021 -0700 Update cosmos_start.bat commit cae55161c6d5cf564f192a8de95baf2d6789d49e Author: van Andel, Gerhard <[email protected]> Date: Thu Mar 4 16:13:10 2021 -0700 Update prometheus.yml commit 1d550d61bd5b2de2ca421151ba793bf9c061c003 Author: van Andel, Gerhard <[email protected]> Date: Thu Mar 4 15:56:55 2021 -0700 Remove aggregator add to cmd/tlm * Update to Redis 6.2 * Add Store.trim_topic * Trim redis stream on log file close * Fix redis tag * Fix bug in cleanup_microservice * Better MicroserviceModel options for LogMicroservice * frontend-init and npm default port * Pull request #40: Update yaml and metrics docs Merge in COSMOSEE/base from metrics-cleanup-bug to master Squashed commit of the following: commit 810c3710291ba8f83e3997160e56d18e542a3189 Author: van Andel, Gerhard <[email protected]> Date: Mon Mar 8 11:26:54 2021 -0700 Update prometheus.yml commit ecf38140f118e7078bf9f6761f35d3a496f0a5d7 Author: van Andel, Gerhard <[email protected]> Date: Mon Mar 8 11:25:45 2021 -0700 Update yaml and metrics docs * Add LIMIT arg to xtrim * Fix store instance method calls * Fix S3 listing oldest files * Remove extraneous params from ActionCable subscription * Change xtrim default limit * Add renaming of DataViewer tabs * Add CMD support to DataViewer * Fix S3 oldest sort * Add saving and loading configs to TlmViewer * Preserve order of TlmViewer screens * Rename minMaxScreen to refreshLayout * Make TlmGrapher remember the last used config * Rename Graph to GraphScreen * Start refactoring plot * Require enterprise all at once * Revert "Require enterprise all at once" This reverts commit 6332cc5. * Fix utilities autoload * Revert "Start refactoring plot" This reverts commit ceb6237. * Revert "Rename Graph to GraphScreen" This reverts commit aca4752. * Add LinegraphWidget * Add LinegraphWidget settings * Add TabbookWidget * Refresh layout on tab change * Fix boolean prop defaults * define ForbiddenError class * Add id.length check in write_entry * Update to remove fluentd * rm cosmos-frontend-init * Add classification banner settings page * Add classification banners * Implement saving and loading classification banner * Move classification banner code to own component * Add configurable font color for classification banners * Add error and success alerts for classification banner settings * Authorize save_setting for global settings * Add settings to clear localStorage items * Consolidate s3 * Add token to api calls * Revert TimeCheck * Remove meta content IE * Add astro icons to vuetify * Add astro status icons * cmd_tlm_api\app\controllers\tools_controller.rb * Working single-spa * Add Api JS and use throughout * Fix status icons size and position * Fix scripts * Document widgets and fix specs * Replace mdi icons with astro ones * Add components for astro status badges * fix merge errors with TlmViewer * Change "forget" to "clear" * fix vscode * fix bugs * Refactor api.js * Explictly set DEFAULT scope in init scripts * merge icon changes. Recreate RuxIcon. Still needs a little love * Fix RuxIcon Scaling * Rever DEFAULT and add dockerignore * Fix merge and add placeholder * Fix cosmos-tool-base references * Remove menu code * dont require auth for tools#show * Change from astro svg to png status indicators * Add notifications backend classes * Fix thread_setup * Add notifications frontend * Add support for getting notification history * Clean up notifications frontend styling * Add red limit notification * fix typo * Status Indicators for notifications * Update URLs for cypress tests * tmp-fix-for-mime-error * Fix small notification bug * Remove stylesheet CDNs * Remove javascript CDNs * Register AstroStatusIndicator globally * Use global AstroStatusIndicator registration * Revert "tmp-fix-for-mime-error" This reverts commit 3d5120f. * Update rails version * fix traefik static * Update specs * improve commenting * Remove Logger.stdout * Update more specs * Fix TargetPacketItemChooser description * Fix topics_thread * Add README to frontend and ignore Gemfile.lock * Update script commands * Fix typo * Remove old methods and ignore running_script in stack * Add nyc cwd * Remove dev-libs import map overrides * Update scripts to fail on error * Account for nav drawer in graph width * Truncate to 100 notifications on frontend * Remove dot from notifications * Fix notification read logic * Fix console error * Pull request #62: Cosmos ruby and node Merge in COSMOSEE/base from cosmos-ruby-and-node to master Squashed commit of the following: commit e1d3b69149863d84b5060b87c538e6490bbe422f Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 1 16:53:58 2021 -0600 dockerfile working commit 755f19476d3be23e0adae4d1d6a030ac3a90827e Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 1 16:11:06 2021 -0600 update dockerfile for cosmos code update commit 6bd502b235cd2a79e8d0efe6e1316d55fee78fcf Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 1 15:12:08 2021 -0600 Entrypoint on base containers fooled me commit 9900ce67e2e8b78af0c89e1f67743118d81c9e95 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 1 11:57:25 2021 -0600 Working test commit cfe3108dc3cba5d811633368a0e1dd7c5b492256 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 1 11:31:29 2021 -0600 Update to add docker-build.sh file commit e4a980d1b8d6101f150345406a2eb8eb34cf1839 Author: van Andel, Gerhard <[email protected]> Date: Wed Mar 31 16:20:28 2021 -0600 Update Dockerfile commit b6c296c529ee1fbb651ddb552eedac5e26c107de Author: van Andel, Gerhard <[email protected]> Date: Tue Mar 30 17:59:39 2021 -0600 Update dockerfiles to make build * Remove nyc config * Reload plugins * Use existing variables * Fix specs * Fix warnings * fix start script * Fix install plugin * ensure config bucket exists for microservice operator * fix webpack-config-single-spa version * Set executable flag on all bash scripts so they can be run * Fix microservice operator spec * Add text logging * Add notification logging * Pull request #70: kebab-case-cosmos Merge in COSMOSEE/base from kebab-case-cosmos to master Squashed commit of the following: commit eb08f19239215319fc09197ffaea823784f8c61a Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 20:49:54 2021 -0600 cosmos_start commit 249ba7ba17013205177d375fcc7de9d8820471e8 Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 20:40:00 2021 -0600 remove curl test commit bf7843c9b70c3f0532bdd6ff0c73cf2484e60f4a Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 20:09:04 2021 -0600 package update commit d8a011c6814395fae033160ef531d32c6de71940 Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 16:15:42 2021 -0600 update to better logs commit f66f0392bbecd3f03c5e663202ed2fcb77558e12 Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 15:15:42 2021 -0600 kebab-case-cosmos * Fix yaml spec * Comment out microservice spec expect * Change to traefik paths * Rename channel prefix * Fix api host and path * Set script-api prefix everywhere * Default redis is cosmos-redis * Update cypress package.json * Clean up dependencies * Clean up devDependencies * Update package-lock.jsons * Fix auto-format * Fix styling on ValueWidget * merge master * Fix script error handling * Pull request #74: Alpine image Merge in COSMOSEE/base from alpine-image to master Squashed commit of the following: commit f76030a24f4580bfee9096a5e1d55e408c751e68 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 17:13:34 2021 -0600 update from feedback commit 636dc2432ee26613533d3696e7fb07e3a9ad7ded Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 16:23:22 2021 -0600 update to init commit 9ba2cc9dc9b061174c5079f8740bd628731200cf Merge: 7ff7678c e351415 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 15:11:27 2021 -0600 merge commit 7ff7678ca6367a944e37d5e9cb65f9aeee7747f5 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 15:08:36 2021 -0600 update dockerfile commit 845f926d153674884b256a05f914c134aa79af0d Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 14:02:10 2021 -0600 .dockerignore error commit ed74782bff4a8df2cf4f832677fa525cfda8ecc3 Merge: 78632c72 0c9921f Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 11:56:23 2021 -0600 update dockerfile commit 78632c722f3cae700f2d77754b13b99cfa5f56f7 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 11:41:11 2021 -0600 this should work commit f5d3942847a17e7b481eafc5974a592632629c89 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 10:53:33 2021 -0600 update dockerignore commit d21d09c951481a559ab8b4f4eab276143daa1161 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 10:04:52 2021 -0600 better build xp maybe... commit 3d52f781d6905ed2386bf0638d72adaf79dd205a Author: van Andel, Gerhard <[email protected]> Date: Wed Apr 7 19:46:39 2021 -0600 working gem server on alpine commit 43eb80dc6e10a1305380befb445d205a36bd850b Author: van Andel, Gerhard <[email protected]> Date: Wed Apr 7 17:44:32 2021 -0600 update for end of day commit b5d6ff197419c2fe96ba58184fdabc7a5c84e914 Author: van Andel, Gerhard <[email protected]> Date: Wed Apr 7 17:32:46 2021 -0600 something like this * Copy on write scripts * Add *.so to dockerignore to prevent local compiled files from getting copied in * Move logging stuff into same folder * Start log_writer refactor * Ignore flaky test * admin updates * Add edit Dialog * Fix a couple things * Fix a couple more things * destroy not undeploy * Remove space before star * Remove extra alert. Fix script options * Improve LogMessages performance * switch to targets_modified * Fix text log filenames * Write log messages to file * Bump pool to 100 and remove latest screen * Change webpack-config-single-spa back to 2.1.1 * update for enterprise-cosmos * Create manual.yml workflow Allow manually command execution Co-authored-by: Pratt, Ryan <[email protected]> Co-authored-by: Thomas, Jason (Software) <[email protected]> Co-authored-by: van Andel, Gerhard <[email protected]> Co-authored-by: Melton, Ryan <[email protected]> Co-authored-by: Wayne Piekarski <[email protected]>
RubenFixit
referenced
this issue
in RubenFixit/COSMOS
Apr 24, 2021
* Update specs * Update packet_log_reader * Rename entry type mask * Remove RUBYLIB and bundle exec * Address PR feedback * Update streaming_api for new log file changes * Fix streaming api file search * Add debug and fix base Dockerfile * Revert "Remove RUBYLIB and bundle exec" This reverts commit 9485a04. * Update specs * Add RUBYLIB in cosmos-base * Clarify comment * Add dockerignores * Remove comments * Pull request #35: Add utc data extractor Merge in COSMOSEE/base from add-utc-data-extractor to master Squashed commit of the following: commit d43dce4978d61a1695972b155d39e881ad89f9f6 Author: van Andel, Gerhard <[email protected]> Date: Thu Mar 4 16:48:00 2021 -0700 Update DataExtractor.vue remove values as they are not used commit 06dfe178c4f47a5033f31541ec8660fc400b17e4 Author: van Andel, Gerhard <[email protected]> Date: Thu Mar 4 14:54:14 2021 -0700 Update DataExtractor.vue commit 8271c99560f1e45d4d75aae9b0161286dd45383e Author: van Andel, Gerhard <[email protected]> Date: Thu Mar 4 14:16:02 2021 -0700 Update DataExtractor.vue * clean up corner cases and validate utc is working commit 32a8f5ec77fdf45542a582a9a5f6b873a8b2866f Author: van Andel, Gerhard <[email protected]> Date: Wed Mar 3 17:24:48 2021 -0700 Update DataExtractor.vue Maybe this.... commit f1de3bdc43a396edad703ce52904b616f0a67544 Author: van Andel, Gerhard <[email protected]> Date: Wed Mar 3 16:47:32 2021 -0700 Update DataExtractor.vue This could be working commit bb8e0e2114797a501ea6211e76113bbfab972c59 Author: van Andel, Gerhard <[email protected]> Date: Wed Mar 3 13:13:02 2021 -0700 Revert "This is broken" This reverts commit 246af5bbfd26237f0d2a9d8ad17a0cc729382a4e. commit 246af5bbfd26237f0d2a9d8ad17a0cc729382a4e Author: van Andel, Gerhard <[email protected]> Date: Wed Mar 3 10:29:21 2021 -0700 This is broken * Pull request #36: Remove aggregator add to cmd/tlm Merge in COSMOSEE/base from remove-aggregaotr-add-to-cmd-tlm-api to master Squashed commit of the following: commit fdde94e07833d002b1e07a461fde74730d2c51e1 Author: van Andel, Gerhard <[email protected]> Date: Fri Mar 5 10:03:29 2021 -0700 Delete .dockerignore commit f459efd896f6edbb8cfcd27ec48086db3f994c3c Merge: dbba4c83 1586d46 Author: van Andel, Gerhard <[email protected]> Date: Fri Mar 5 10:03:06 2021 -0700 Merge branch 'master' of https://bitbucket.aero.ball.com/bitbucket/scm/cosmosee/base into remove-aggregaotr-add-to-cmd-tlm-api commit dbba4c8351c905fc5384ab6fa3c6a0ddffbfa7f6 Author: van Andel, Gerhard <[email protected]> Date: Fri Mar 5 10:00:26 2021 -0700 Update cosmos_start.bat commit cae55161c6d5cf564f192a8de95baf2d6789d49e Author: van Andel, Gerhard <[email protected]> Date: Thu Mar 4 16:13:10 2021 -0700 Update prometheus.yml commit 1d550d61bd5b2de2ca421151ba793bf9c061c003 Author: van Andel, Gerhard <[email protected]> Date: Thu Mar 4 15:56:55 2021 -0700 Remove aggregator add to cmd/tlm * Update to Redis 6.2 * Add Store.trim_topic * Trim redis stream on log file close * Fix redis tag * Fix bug in cleanup_microservice * Better MicroserviceModel options for LogMicroservice * frontend-init and npm default port * Pull request #40: Update yaml and metrics docs Merge in COSMOSEE/base from metrics-cleanup-bug to master Squashed commit of the following: commit 810c3710291ba8f83e3997160e56d18e542a3189 Author: van Andel, Gerhard <[email protected]> Date: Mon Mar 8 11:26:54 2021 -0700 Update prometheus.yml commit ecf38140f118e7078bf9f6761f35d3a496f0a5d7 Author: van Andel, Gerhard <[email protected]> Date: Mon Mar 8 11:25:45 2021 -0700 Update yaml and metrics docs * Add LIMIT arg to xtrim * Fix store instance method calls * Fix S3 listing oldest files * Remove extraneous params from ActionCable subscription * Change xtrim default limit * Add renaming of DataViewer tabs * Add CMD support to DataViewer * Fix S3 oldest sort * Add saving and loading configs to TlmViewer * Preserve order of TlmViewer screens * Rename minMaxScreen to refreshLayout * Make TlmGrapher remember the last used config * Rename Graph to GraphScreen * Start refactoring plot * Require enterprise all at once * Revert "Require enterprise all at once" This reverts commit 6332cc5. * Fix utilities autoload * Revert "Start refactoring plot" This reverts commit ceb6237. * Revert "Rename Graph to GraphScreen" This reverts commit aca4752. * Add LinegraphWidget * Add LinegraphWidget settings * Add TabbookWidget * Refresh layout on tab change * Fix boolean prop defaults * define ForbiddenError class * Add id.length check in write_entry * Update to remove fluentd * rm cosmos-frontend-init * Add classification banner settings page * Add classification banners * Implement saving and loading classification banner * Move classification banner code to own component * Add configurable font color for classification banners * Add error and success alerts for classification banner settings * Authorize save_setting for global settings * Add settings to clear localStorage items * Consolidate s3 * Add token to api calls * Revert TimeCheck * Remove meta content IE * Add astro icons to vuetify * Add astro status icons * cmd_tlm_api\app\controllers\tools_controller.rb * Working single-spa * Add Api JS and use throughout * Fix status icons size and position * Fix scripts * Document widgets and fix specs * Replace mdi icons with astro ones * Add components for astro status badges * fix merge errors with TlmViewer * Change "forget" to "clear" * fix vscode * fix bugs * Refactor api.js * Explictly set DEFAULT scope in init scripts * merge icon changes. Recreate RuxIcon. Still needs a little love * Fix RuxIcon Scaling * Rever DEFAULT and add dockerignore * Fix merge and add placeholder * Fix cosmos-tool-base references * Remove menu code * dont require auth for tools#show * Change from astro svg to png status indicators * Add notifications backend classes * Fix thread_setup * Add notifications frontend * Add support for getting notification history * Clean up notifications frontend styling * Add red limit notification * fix typo * Status Indicators for notifications * Update URLs for cypress tests * tmp-fix-for-mime-error * Fix small notification bug * Remove stylesheet CDNs * Remove javascript CDNs * Register AstroStatusIndicator globally * Use global AstroStatusIndicator registration * Revert "tmp-fix-for-mime-error" This reverts commit 3d5120f. * Update rails version * fix traefik static * Update specs * improve commenting * Remove Logger.stdout * Update more specs * Fix TargetPacketItemChooser description * Fix topics_thread * Add README to frontend and ignore Gemfile.lock * Update script commands * Fix typo * Remove old methods and ignore running_script in stack * Add nyc cwd * Remove dev-libs import map overrides * Update scripts to fail on error * Account for nav drawer in graph width * Truncate to 100 notifications on frontend * Remove dot from notifications * Fix notification read logic * Fix console error * Pull request #62: Cosmos ruby and node Merge in COSMOSEE/base from cosmos-ruby-and-node to master Squashed commit of the following: commit e1d3b69149863d84b5060b87c538e6490bbe422f Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 1 16:53:58 2021 -0600 dockerfile working commit 755f19476d3be23e0adae4d1d6a030ac3a90827e Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 1 16:11:06 2021 -0600 update dockerfile for cosmos code update commit 6bd502b235cd2a79e8d0efe6e1316d55fee78fcf Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 1 15:12:08 2021 -0600 Entrypoint on base containers fooled me commit 9900ce67e2e8b78af0c89e1f67743118d81c9e95 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 1 11:57:25 2021 -0600 Working test commit cfe3108dc3cba5d811633368a0e1dd7c5b492256 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 1 11:31:29 2021 -0600 Update to add docker-build.sh file commit e4a980d1b8d6101f150345406a2eb8eb34cf1839 Author: van Andel, Gerhard <[email protected]> Date: Wed Mar 31 16:20:28 2021 -0600 Update Dockerfile commit b6c296c529ee1fbb651ddb552eedac5e26c107de Author: van Andel, Gerhard <[email protected]> Date: Tue Mar 30 17:59:39 2021 -0600 Update dockerfiles to make build * Remove nyc config * Reload plugins * Use existing variables * Fix specs * Fix warnings * fix start script * Fix install plugin * ensure config bucket exists for microservice operator * fix webpack-config-single-spa version * Set executable flag on all bash scripts so they can be run * Fix microservice operator spec * Add text logging * Add notification logging * Pull request #70: kebab-case-cosmos Merge in COSMOSEE/base from kebab-case-cosmos to master Squashed commit of the following: commit eb08f19239215319fc09197ffaea823784f8c61a Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 20:49:54 2021 -0600 cosmos_start commit 249ba7ba17013205177d375fcc7de9d8820471e8 Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 20:40:00 2021 -0600 remove curl test commit bf7843c9b70c3f0532bdd6ff0c73cf2484e60f4a Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 20:09:04 2021 -0600 package update commit d8a011c6814395fae033160ef531d32c6de71940 Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 16:15:42 2021 -0600 update to better logs commit f66f0392bbecd3f03c5e663202ed2fcb77558e12 Author: van Andel, Gerhard <[email protected]> Date: Mon Apr 5 15:15:42 2021 -0600 kebab-case-cosmos * Fix yaml spec * Comment out microservice spec expect * Change to traefik paths * Rename channel prefix * Fix api host and path * Set script-api prefix everywhere * Default redis is cosmos-redis * Update cypress package.json * Clean up dependencies * Clean up devDependencies * Update package-lock.jsons * Fix auto-format * Fix styling on ValueWidget * merge master * Fix script error handling * Pull request #74: Alpine image Merge in COSMOSEE/base from alpine-image to master Squashed commit of the following: commit f76030a24f4580bfee9096a5e1d55e408c751e68 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 17:13:34 2021 -0600 update from feedback commit 636dc2432ee26613533d3696e7fb07e3a9ad7ded Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 16:23:22 2021 -0600 update to init commit 9ba2cc9dc9b061174c5079f8740bd628731200cf Merge: 7ff7678c e351415 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 15:11:27 2021 -0600 merge commit 7ff7678ca6367a944e37d5e9cb65f9aeee7747f5 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 15:08:36 2021 -0600 update dockerfile commit 845f926d153674884b256a05f914c134aa79af0d Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 14:02:10 2021 -0600 .dockerignore error commit ed74782bff4a8df2cf4f832677fa525cfda8ecc3 Merge: 78632c72 0c9921f Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 11:56:23 2021 -0600 update dockerfile commit 78632c722f3cae700f2d77754b13b99cfa5f56f7 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 11:41:11 2021 -0600 this should work commit f5d3942847a17e7b481eafc5974a592632629c89 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 10:53:33 2021 -0600 update dockerignore commit d21d09c951481a559ab8b4f4eab276143daa1161 Author: van Andel, Gerhard <[email protected]> Date: Thu Apr 8 10:04:52 2021 -0600 better build xp maybe... commit 3d52f781d6905ed2386bf0638d72adaf79dd205a Author: van Andel, Gerhard <[email protected]> Date: Wed Apr 7 19:46:39 2021 -0600 working gem server on alpine commit 43eb80dc6e10a1305380befb445d205a36bd850b Author: van Andel, Gerhard <[email protected]> Date: Wed Apr 7 17:44:32 2021 -0600 update for end of day commit b5d6ff197419c2fe96ba58184fdabc7a5c84e914 Author: van Andel, Gerhard <[email protected]> Date: Wed Apr 7 17:32:46 2021 -0600 something like this * Copy on write scripts * Add *.so to dockerignore to prevent local compiled files from getting copied in * Move logging stuff into same folder * Start log_writer refactor * Ignore flaky test * admin updates * Add edit Dialog * Fix a couple things * Fix a couple more things * destroy not undeploy * Remove space before star * Remove extra alert. Fix script options * Improve LogMessages performance * switch to targets_modified * Fix text log filenames * Write log messages to file * Bump pool to 100 and remove latest screen * Change webpack-config-single-spa back to 2.1.1 * update for enterprise-cosmos * Create manual.yml workflow Allow manually command execution Co-authored-by: Pratt, Ryan <[email protected]> Co-authored-by: Thomas, Jason (Software) <[email protected]> Co-authored-by: van Andel, Gerhard <[email protected]> Co-authored-by: Melton, Ryan <[email protected]> Co-authored-by: Wayne Piekarski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
User's have requested that ask() take a default value as many times they are asking for multiple parameters but only one actually changes. The current API is ask(question, allow_blank = false, password = false). Password was just added in 3.2.0. I don't want to break the API but I feel like the default parameter should be second as it's more likely to be used than blank and password. I also think blank is least likely and should be last. Should we create a new method "ask_default" and eventually switch ask to it after a deprecation warning? Or do we continue to simply tack on parameter to the end of methods without any though of usage and consistency?
The text was updated successfully, but these errors were encountered: