Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sound to COSMOS alerts #133

Closed
jmthomas opened this issue May 19, 2015 · 2 comments
Closed

Add sound to COSMOS alerts #133

jmthomas opened this issue May 19, 2015 · 2 comments
Labels
feature
Milestone
v3.5.0

Comments

@jmthomas
Copy link
Contributor

Our users would like to have alert sounds when Script dialogs popup to notify the user during long script executions. I also wonder if yellow and/or red limit violations should have some sort of alert sound. We already have a "production" flag in the server which could potentially be used to enable sound alerts as well. However, due to the potentially annoyance of sound maybe there is a separate flag to explicitly disable sound?

I think overriding the Qt::MessageBox methods would allow us to add sound to popups relatively easily.
@ghost
Copy link

ghost commented May 19, 2015

You can make this a setting in system.txt. Default off.

jmthomas added a commit that referenced this issue May 19, 2015
@jmthomas
Add sound option to System and enable sound in alerts #133
c0b6fc5
ghost pushed a commit that referenced this issue May 19, 2015
@ryanmelt
#133. Refactor play_wav_file to one location. Update naming
7ff3003
jmthomas added a commit that referenced this issue May 19, 2015
@jmthomas
Merge pull request #134 from BallAerospace/add_sound
20354b7 
Add sound option to System and enable sound in alerts #133
@ghost
Copy link

ghost commented May 20, 2015

closed by pull request #134

@ghost ghost closed this as completed May 20, 2015
@ghost ghost added the feature label Jun 11, 2015
@ghost ghost modified the milestone: v3.5.0 Jun 22, 2015
ghost pushed a commit that referenced this issue Jul 1, 2021
Pull request #133: Dockerfile update 3.12
aaf4b61 
Merge in COSMOSEE/base from dockerfile-update-3.12 to master

Squashed commit of the following:

commit defa4386d459078fd675357b8aa4e3cf719482ee
Author: van Andel, Gerhard <[email protected]>
Date:   Mon Jun 21 09:59:25 2021 -0600

    feedback from pull request

commit 74405f89e0c12e7a29391e815692fc986012d521
Author: van Andel, Gerhard <[email protected]>
Date:   Fri Jun 18 17:18:10 2021 -0600

    update to 3.12.0
@weinrich15 weinrich15 mentioned this issue Nov 23, 2023
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v3.5.0
Development

No branches or pull requests
1 participant
@jmthomas