One less dependency! #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Balastrong
requested changes
Oct 4, 2022
| @@ -1,8 +1,9 @@ | |||
| import axios from 'axios'; | |||
| import fetch from './fetch'; | |||
There was a problem hiding this comment.
Is there any particular reason why reimplementing fetch and not using the native fetch method?
There was a problem hiding this comment.
because native fetch not is in node LTS version. (only 17.5^)
src/uti.ts
Outdated
Comment on lines
22
to
32
| let games: Game[] = []; | ||
| const archives = await getChessComArchives(chessUsername); | ||
|
|
||
| for (const archive of archives) { | ||
| const gamesInArchive = await getChessComGames(archive); | ||
| if (gamesInArchive.length > 0) { | ||
| games.push(...gamesInArchive.reverse()); | ||
| } | ||
|
|
||
| if (games.length >= amount) { | ||
| return games.slice(0, amount); | ||
| if (games.length < amount) { | ||
| const gamesInArchive = await getChessComGames(archive); | ||
| games = [...games, ...gamesInArchive.reverse()]; | ||
| } | ||
| } | ||
|
|
||
| return games; | ||
| return games.slice(0, amount); |
There was a problem hiding this comment.
This actually changes the logic, we previously looked for max 5 archives and return early, now you loop through all archives in any case.
Is there a particular reason for this change?
There was a problem hiding this comment.
I forgot to break the loop XD
for (const archive of archives) {
if (games.length < amount) {
const gamesInArchive = await getChessComGames(archive);
games = [...games, ...gamesInArchive.reverse()];
} else { break }
}
Balastrong
approved these changes
Oct 5, 2022
|
LGTM, thanks for the PR! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I removed axios and replaced it with http. (fetch.ts, api.ts)
and I change somethings...