Update WindowEvent.__eq__ #366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baekalfen
force-pushed
the
windowevent-fix
branch
2 times, most recently
from
66912b6 to
b1b24c9
Compare
Baekalfen
reviewed
Feb 12, 2025
Comment on lines
+229
to
+234
| def __eq__(self, other): | ||
| if isinstance(other, WindowEvent): | ||
| return self.__event == other.__event | ||
| elif isinstance(other, int): | ||
| return self.__event == other | ||
| return NotImplemented |
There was a problem hiding this comment.
I see it's correct to do return NotImplemented. Can you write a test case that demonstrates it?
There was a problem hiding this comment.
Possibly, add a test case that demonstrates that not only a == b works, but also b == a. This is probably done at the same time.
Comment on lines
+4
to
+5
|
|
||
|
|
There was a problem hiding this comment.
I removed the initial test case, as it was testing internal functionality. I've corrected this by changing the code where the internal variable was erroneously used.
Baekalfen
force-pushed
the
windowevent-fix
branch
from
b1b24c9 to
b3180a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures proper delegation to
other.__eq__in case of comparisons with unrelated types and avoid raiseAttributeErrorwhen trying to compare with objects not havingeventattribute