Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Upgrade to SSDK 16 and 2023.12 #393

Merged
merged 18 commits into from
Dec 28, 2023

Conversation

Aboruhen
Copy link
Contributor

Description

Upgrade modules to SSDK 16 & BB-BOM 2023.12

Checklist

  • I made sure, I read CONTRIBUTING.md to put right branch prefix as per my need.
  • I made sure to update CHANGELOG.md.
  • I made sure to update Stream Wiki(only valid in case of new stream module or architecture changes).
  • My changes are adequately tested.
  • I made sure all the SonarCloud Quality Gate are passed.

@Aboruhen Aboruhen requested a review from a team as a code owner December 15, 2023 14:57
@uesleilima uesleilima changed the base branch from master to develop December 15, 2023 15:58
@uesleilima uesleilima changed the title Feature/upgrade ssdk 16 and 2023 12 [develop] Upgrade to SSDK 16 and 2023.12 Dec 15, 2023
<groupId>com.backbase.stream</groupId>
<artifactId>legal-entity-core</artifactId>
<version>${project.version}</version>
<exclusions>
Copy link
Collaborator

@uesleilima uesleilima Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legal-entity-core doesn't have sleuth dependency anymore, so this exclusion is redundant, perhaps you are building the composition modules to test without building the legal-entity-core before

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps there are some other transitive dependencies... anyway, I will fix this after the upgrade. In case if it's the only point of check

@Aboruhen Aboruhen requested a review from uesleilima December 22, 2023 14:08
@uesleilima uesleilima force-pushed the feature/upgrade-SSDK-16-and-2023-12 branch from e5d561d to 6ee6255 Compare December 28, 2023 09:52
@uesleilima uesleilima force-pushed the feature/upgrade-SSDK-16-and-2023-12 branch from 6ee6255 to 54ee31a Compare December 28, 2023 10:01
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

68.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Collaborator

@uesleilima uesleilima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the outstanding effort @Aboruhen !

@uesleilima uesleilima merged commit 66b47e1 into develop Dec 28, 2023
2 of 3 checks passed
@uesleilima uesleilima deleted the feature/upgrade-SSDK-16-and-2023-12 branch December 28, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants