Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle update job role HTTP 207 multi-status response #177

Closed
wants to merge 2 commits into from
Closed

Handle update job role HTTP 207 multi-status response #177

wants to merge 2 commits into from

Conversation

rj93
Copy link
Contributor

@rj93 rj93 commented Jul 7, 2022

Fixes #176

@rj93 rj93 requested a review from a team as a code owner July 7, 2022 13:01
bartveenstra
bartveenstra reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@bartveenstra bartveenstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Make the entire request fail as we won't have slippage of accounts not ingested.

@rj93 rj93 force-pushed the bug/update-job-role-multi-status-response branch from 506181f to 74ca477 Compare July 14, 2022 07:38
@uesleilima
Copy link
Collaborator

@rj93 we have a problem in the GH workflow where it doesn't convey with PR from forks, I gave you write access to the repository so please use it instead of your fork

@rj93
Copy link
Contributor Author

rj93 commented Jul 15, 2022

Replaced by #182

@rj93 rj93 closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartveenstra bartveenstra bartveenstra left review comments

@uesleilima uesleilima uesleilima approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Job Role does not consider the 207 multi-status response
3 participants
@rj93 @uesleilima @bartveenstra