Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ffs intrinsic for MSVC #104

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Fix ffs intrinsic for MSVC #104

merged 1 commit into from
Feb 3, 2020

Conversation

mworchel
Copy link
Contributor

@mworchel mworchel commented Feb 3, 2020

The intrinsic ffs was returning the first set MSB instead of LSB, which is now fixed by scanning the mask from LSB to MSB.

@mworchel mworchel mentioned this pull request Feb 3, 2020
Closed
@BachiLi
Copy link
Owner

BachiLi commented Feb 3, 2020

Thanks!

@BachiLi BachiLi merged commit b4f5703 into BachiLi:master Feb 3, 2020
@mworchel mworchel deleted the fix-msvc-ffs branch February 5, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mworchel @BachiLi