Skip to content

Commit

Permalink
continuous-integration.yml: use one job to collect the status of all …
Browse files Browse the repository at this point in the history
…jobs in the workflow

That we can use one required status check in the branch protection rules.
This allows to:
- Allows review of the settings which jobs should be required. The merge of a pr leads to the new settings being active
- Not having to synchronize the settings of the required status check with the devel branch.
This happens automatically because the configuration is checked in.
- Not having to merge/rebase devel because the names of the jobs changed but the old/new job
names are in the required status checks.
(see ecamp#4204 (comment))
  • Loading branch information
BacLuc committed Dec 24, 2023
1 parent e9194ea commit 0abb10b
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -389,10 +389,9 @@ jobs:
parallel-finished: true
carryforward: "api,frontend,print,pdf"
fail-on-error: false

ci-passed-event:
name: 'Send out CI success event'
if: github.event_name == 'push' && (github.event.pull_request && github.event.pull_request.number)

workflow-success:
name: workflow-success
needs:
- api-cs-check
- frontend-eslint
Expand All @@ -403,6 +402,15 @@ jobs:
- print-tests
- e2e-tests-run
runs-on: ubuntu-latest
steps:
- run: exit 0

ci-passed-event:
name: 'Send out CI success event'
if: github.event_name == 'push' && (github.event.pull_request && github.event.pull_request.number)
needs:
- workflow-success
runs-on: ubuntu-latest
steps:
- uses: peter-evans/repository-dispatch@bf47d102fdb849e755b0b0023ea3e81a44b6f570 # v2
with:
Expand Down

0 comments on commit 0abb10b

Please sign in to comment.