Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support relative paths for custom set paths for KhronosTextureContainer2 #13158

Closed
Steffen-T opened this issue Oct 24, 2022 · 2 comments · Fixed by #13160
Closed

Support relative paths for custom set paths for KhronosTextureContainer2 #13158

Steffen-T opened this issue Oct 24, 2022 · 2 comments · Fixed by #13160
Assignees
@bghgary
Labels
enhancement texture
Milestone
6.0

Comments

@Steffen-T
Copy link

Can't use relative paths for KhronosTextureContainer2.URLConfig. Only absolute paths work.
Forum discussion suggests a simple Tools.GetAbsoluteUrl is missing.
Perhaps this is also needed for MeshoptCompression.Configuration.

Desktop

  • OS: Windows 10
  • Browser: Chrome
  • Version: 106.0.5249.119
@sebavan
Copy link
Member

sebavan commented Oct 24, 2022

@bghgary feel free to reassign if needed ?

@thomlucc thomlucc added enhancement and removed bug labels Oct 24, 2022
@thomlucc thomlucc added this to the 6.0 milestone Oct 24, 2022
@bghgary
Copy link
Contributor

bghgary commented Oct 24, 2022

MeshoptCompression already supports relative urls: https://github.com/bghgary/Babylon.js/blob/c599fb01de51ab3eba031c8d1d3c609351e8aa23/packages/dev/core/src/Meshes/Compression/meshoptCompression.ts#L81

@bghgary bghgary changed the title Support relative paths for custom set paths for KhronosTextureContainer2 and MeshoptCompression Support relative paths for custom set paths for KhronosTextureContainer2 Oct 24, 2022
@bghgary bghgary mentioned this issue Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bghgary bghgary

Labels
enhancement texture
Projects
None yet
Milestone
6.0
Development

Successfully merging a pull request may close this issue.

Support relative urls in KTX2 configuration bghgary/Babylon.js
4 participants
@sebavan @bghgary @thomlucc @Steffen-T