Keep track of the layer graph #2073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just keeping track of input and output blobs, also keep track of layer dependencies. (Also adjust AppendBottom's argument types to avoid passing an input as a pointer.)
| @@ -369,17 +383,21 @@ void Net<Dtype>::AppendTop(const NetParameter& param, const int layer_id, | |||
| template <typename Dtype> | |||
| int Net<Dtype>::AppendBottom(const NetParameter& param, | |||
| const int layer_id, const int bottom_id, | |||
| set<string>* available_blobs, map<string, int>* blob_name_to_idx) { | |||
| set<string>* available_blobs, const map<string, int>& blob_name_to_idx, | |||
| const map<int, int>& top_blob_idx_to_layer) { | |||
There was a problem hiding this comment.
available_blobs should be last arg
|
LGTM other than my style comment. Ideally it'd have a test or two but I guess it can't break anything given that it's just adding some new member vars... |
19 tasks
|
There is a very simple solution to manage the forward and backward computation of the predecessors and successors in a general flow graph. |
|
Closing as #2219 was closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Netkeeps track of each layer's input and output blobs. However, since layers can be in-place, this information isn't sufficient to easily obtain the dependencies present in the computation graph.This PR adds
layer_parentsandlayer_childrentoNet. The parents of a layer (index) are the layers (indices) whose forwards must come before that layer's forward. The children of a layer are the layers whose backwards must come before that layer's backward.Note that the hard distinction that we've maintained so far between backward and forward means that there are additional, untracked dependencies in the computation graph; namely, a layer's forward must come before its backward. I don't anticipate any serious consequences of this.
This graph will be used in a future PR, to allow correct multithreaded computation.