New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better sftp cleaning and download logging #280

Merged

Shettland merged 4 commits into BU-ISCIII:develop from Shettland:develop

Jul 18, 2024

Member

Shettland commented Jul 16, 2024

This PR includes several changes to download module to improve its functionalities:

Cleaning process after download now skips sequencing files left in remote repository due to validation failure
Temporary files are correctly removed from local folder
Better logs overall, more info is included (such as processed folders and corrupted files)
No output_location/downloaded_folder/$DATE/ folder is created inside the downloaded folder as tmp_processing_DATE already includes the date


          Better sftp cleaning and download logging

0bb8554

Daniel-VM self-requested a review

July 16, 2024 09:44


          Better remote cleaning. Fix1

f7338ff

Daniel-VM approved these changes

View reviewed changes

Member

Daniel-VM left a comment

LGTM

Shettland added 2 commits

July 18, 2024 16:30


          Removed tmp_processing from downloaded folder name

41f6fa2


          updated sftp_handle. Linting

6d59222

Shettland merged commit b2ca092 into BU-ISCIII:develop

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet