Refactor of read-bioinfo-metadata module for tool compatibility expansion #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dir level and updated previous method to parse the new bioinfo config file
…at_collated_files
…e paths and validate required files
…lacing old include_custom_data method
Shettland
reviewed
Apr 8, 2024
Shettland
reviewed
Apr 8, 2024
Shettland
reviewed
Apr 9, 2024
Daniel-VM
added a commit
to Daniel-VM/relecov-tools
that referenced
this pull request
Apr 9, 2024
|
It looks very good overall, I'd appreciate if the methods were documented using docstrings. There's a visual studio code extension that helps a lot with this task (autodocstring) |
Daniel-VM
changed the title
Shettland
reviewed
Apr 11, 2024
Shettland
reviewed
Apr 11, 2024
Shettland
reviewed
Apr 11, 2024
Shettland
reviewed
Apr 11, 2024
Shettland
reviewed
Apr 11, 2024
|
I think I have covered all suggestions. and also added a few todos for enhancementss in upcoming versions of this module. |
Shettland
reviewed
Apr 16, 2024
Shettland
approved these changes
Apr 16, 2024
|
Thank you for your feedback! Looking forward to further improving the modules |
Daniel-VM
added a commit
to Daniel-VM/relecov-tools
that referenced
this pull request
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR includes a full refactoring of the
read-bioinfo-metadatamodule, broadening its applicability beyond a single pipeline (as in the old version) to process metadata from any bioinformatics tool or software. Further implementation details can be found in #253.