Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor deps with dep #32

Merged
merged 2 commits into from
Nov 1, 2017
Merged

Vendor deps with dep #32

merged 2 commits into from
Nov 1, 2017

Conversation

hairyhenderson
Copy link
Contributor

As suggested in #29, this vendors in the dependencies.

I did this with:

$ go get -u github.com/golang/dep/cmd/dep
$ dep init

Updates are done with:

$ dep ensure

/cc @BTBurke

@BTBurke
Copy link
Owner

BTBurke commented Oct 28, 2017

Thanks for the contribution. One change that needs to be made is to manually edit the Godep.toml and ignore caddy dependencies. Otherwise this is going to break the Caddy build server.

What we want is just to vendor the core dependency of jwt-go and let the others be managed by the build server.

@hairyhenderson
Copy link
Contributor Author

@BTBurke ah, ok - I understand... I'll see if I can figure out how to get dep to do that...

@BTBurke
Copy link
Owner

BTBurke commented Oct 28, 2017 via email

Signed-off-by: Dave Henderson <[email protected]>
Signed-off-by: Dave Henderson <[email protected]>
@hairyhenderson
Copy link
Contributor Author

@BTBurke ok, I've updated the PR.

The dep status output is now:

$ dep status
PROJECT                      CONSTRAINT  VERSION  REVISION  LATEST   PKGS USED
github.com/dgrijalva/jwt-go  ^3.1.0      v3.1.0   dbeaa93   dbeaa93  1  

@BTBurke BTBurke merged commit f0d142e into BTBurke:master Nov 1, 2017
@BTBurke
Copy link
Owner

BTBurke commented Nov 1, 2017

@hairyhenderson I gave this a shot but unfortunately dep isn't supported by the build server. Caddy won't build as long as the vendored dependencies exist. I may create an issue on the Caddy repo, but it's not a huge deal in the short term as long as the API for the jwt-go dependency is stable.

Thanks for your help on this.

@hairyhenderson hairyhenderson deleted the vendor-deps-with-dep branch November 1, 2017 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants