-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ECR gate #234
Add ECR gate #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for taking this upon yourself to add. This is very much a welcome addition, thanks also for getting the unitary endian ordering correct.
Besides the two minor points below, can you add a test that ensures we can read and write this gate properly to qasm. You may need to a GateDef in the qasm visitor module.
Awesome! Just one more test to get this approved and merged in. Can you do a encode-decode-in-one test? As in create a circuit with an |
Add echoed-resonance (ECR) gate