Merge pull request #76 from BP-WG/fix/master_fp

Fix key source for accounts without master fingerprint
BP-WG · Mar 20, 2024 · 57d1b0d · 57d1b0d
2 parents 9851b2f + 37a5678
commit 57d1b0d
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/hd/src/account.rs b/hd/src/account.rs
@@ -216,9 +216,7 @@ impl DerivationAccount {
     ) -> Result<DerivationPath, DerivePatternError> {
         let mut derivation_path =
             Vec::with_capacity(self.account_path.len() + self.terminal_path.len() + 1);
-        if self.master.is_some() {
-            derivation_path.extend(self.account_path.iter().map(ChildNumber::from));
-        }
+        derivation_path.extend(self.account_path.iter().map(ChildNumber::from));
         derivation_path.extend(&self.to_terminal_derivation_path(pat)?);
         Ok(derivation_path.into())
     }
@@ -236,8 +234,7 @@ impl DerivationAccount {
         Ok((
             self.derive_public_key(ctx, pat.clone())?,
             (
-                self.master_fingerprint()
-                    .unwrap_or_else(|| self.account_fingerprint()),
+                self.master_fingerprint().unwrap_or_default(),
                 self.to_full_derivation_path(pat)?,
             ),
         ))