Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separating opret and tapret anchor types #69

Merged
merged 13 commits into from
Dec 25, 2023
Merged

Separating opret and tapret anchor types #69

merged 13 commits into from
Dec 25, 2023

Conversation

dr-orlovsky
Copy link
Member

Required to cover the cases when both types of commitments are present in a single witness transaction

@dr-orlovsky dr-orlovsky added *consensus* Issues affecting distributed concensus *security* Issues affecting safety/security (include undefined behaviours) refactoring Refactoring of the existing code labels Dec 14, 2023
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Dec 14, 2023
cryptoquick
cryptoquick previously approved these changes Dec 14, 2023
Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (14175ef) 49.6% compared to head (fbdd7f3) 49.0%.

❗ Current head fbdd7f3 differs from pull request most recent head 241eee5. Consider uploading reports for the commit 241eee5 to get more accurate results

Files Patch % Lines
dbc/src/opret/spk.rs 0.0% 22 Missing ⚠️
dbc/src/opret/tx.rs 0.0% 19 Missing ⚠️
dbc/src/opret/txout.rs 0.0% 11 Missing ⚠️
dbc/src/anchor.rs 0.0% 10 Missing ⚠️
dbc/src/opret/mod.rs 25.0% 6 Missing ⚠️
dbc/src/tapret/mod.rs 0.0% 3 Missing ⚠️
seals/src/txout/witness.rs 0.0% 3 Missing ⚠️
consensus/src/script.rs 0.0% 1 Missing ⚠️
dbc/src/tapret/xonlypk.rs 66.7% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           v0.11     #69     +/-   ##
=======================================
- Coverage   49.6%   49.0%   -0.6%     
=======================================
  Files         30      33      +3     
  Lines       3066    3111     +45     
=======================================
+ Hits        1520    1524      +4     
- Misses      1546    1587     +41     
Flag Coverage Δ
rust 49.0% <11.6%> (-0.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky changed the base branch from master to v0.11 December 14, 2023 19:31
@dr-orlovsky dr-orlovsky merged commit 4f93149 into v0.11 Dec 25, 2023
@dr-orlovsky dr-orlovsky deleted the doubleanchors branch December 26, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*consensus* Issues affecting distributed concensus refactoring Refactoring of the existing code *security* Issues affecting safety/security (include undefined behaviours)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants