Write two util functions to get the values and errors in separate num… #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py ndarrays from the list if ValueErrorPairs.
Co-authored-by: Martin Fuchs <[email protected]>
|
Included in #47 |
Benedikt-Brunner
deleted the
core/feature/use-custom-data-model-for-calculations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The functions used for calculating the lifetime$\tau$ are currently using many seperate input parameters, which was only ever a temporary implementation. Now the custom datamodel, implemented in the import/export module, should be used instead.
Additionally to changing the parameters and their usages we also need some util functions to make the custom data model compatible with ndarrays from numpy, used in the core module.
PR checklist
Closes/Fixes/Related to