Light dark mode graph: When switching appearance mode in View Menu, Graph will change color #15
Conversation
Benedikt-Brunner
changed the base branch from
main
to
gui/feature/add-buttons
There was a problem hiding this comment.
Had a look at the UI, i like it 👍
I didn't have much to say here, just some left over print statements.
These changes should be moved to the Graph Widget after it gets separated in the base PR.
Also @julius-kress needs to approve the layouting changes, as i don't have the expertise to comment on that.
napytau/gui/gui_app.py
Outdated
| if appearance == "system": | ||
| main_color = "#151515" | ||
| secondary_color = "#ffffff" | ||
| print("Fall1") |
There was a problem hiding this comment.
These print statements should probably be removed
napytau/gui/gui_app.py
Outdated
| def plot(value: int, window: GUIApp) -> Canvas: | ||
| def plot(value: int, window: GUIApp, appearance: str) -> Canvas: | ||
|
|
||
| print(appearance) |
There was a problem hiding this comment.
remove this aswell
napytau/gui/gui_app.py
Outdated
| @@ -80,6 +80,8 @@ def __init__(self) -> None: | |||
| # Initialize information area | |||
| self._init_information_area() | |||
|
|
|||
| self.appearance_mode.trace_add("write", self.update_plot) | |||
Before. only appearance modes "light" and "dark" would have an effect on graph design. But now appearance mode "system" also, properly works in changing the Graph to the users prefered system theme.
…ppe-80/NaPyTau into Light_Dark_Mode_Graph
Yeah I like the changes as well. Darkmode on the graph makes the GUI look much cleaner. The current graph is still a mockup, but I think we can use this when implementing the actual graph 👍 |
Summary
When switching appearance mode in the View Menu, the Graph will change color. "System" Appearance mode is still being developed.
PR checklist
Depends on
Closes/Fixes/Related to