Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust import statements to match convention #39

Closed
Madddiiiin opened this issue Jan 2, 2025 · 0 comments · Fixed by #43
Closed

Adjust import statements to match convention #39

Madddiiiin opened this issue Jan 2, 2025 · 0 comments · Fixed by #43
Assignees
Labels
Core Related to the "core" module Refactoring Related to a general refactoring of the code

Comments

@Madddiiiin
Copy link
Contributor

Madddiiiin commented Jan 2, 2025

Description

The current situation in the core module is that there is a wild mix between two different approaches to importing functionality from libraries.

The first one is to use:
from numpy import power
...
power(x, y)

The second one is:
import numpy as np
...
np.power(x, y)

The team has decided to go for the second option and so it should be used everywhere.

Acceptance Criteria

  • Every usage of the first option is replaced by the second
  • No functionality is changed
@Madddiiiin Madddiiiin added Core Related to the "core" module Refactoring Related to a general refactoring of the code labels Jan 2, 2025
@Madddiiiin Madddiiiin moved this to Backlog in NaPyTau Development Jan 2, 2025
@arniw2 arniw2 moved this from Backlog to Eingang in NaPyTau Development Jan 2, 2025
@Benedikt-Brunner Benedikt-Brunner changed the title Adjust import statements to match consistent convention Adjust import statements to match convention Jan 2, 2025
@arniw2 arniw2 moved this from Eingang to In Development in NaPyTau Development Jan 2, 2025
@arniw2 arniw2 moved this from In Development to Ready for Review in NaPyTau Development Jan 6, 2025
@Benedikt-Brunner Benedikt-Brunner moved this from Ready for Review to In review in NaPyTau Development Jan 7, 2025
@Madddiiiin Madddiiiin moved this from In review to Ready for Review in NaPyTau Development Jan 8, 2025
@Benedikt-Brunner Benedikt-Brunner moved this from Ready for Review to In review in NaPyTau Development Jan 8, 2025
@Benedikt-Brunner Benedikt-Brunner moved this from In review to Ready for Test in NaPyTau Development Jan 12, 2025
@Benedikt-Brunner Benedikt-Brunner moved this from Ready for Test to Completed in NaPyTau Development Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Related to the "core" module Refactoring Related to a general refactoring of the code
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

2 participants