Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: when update venue, call it a "computer" rather than a "host". #5206

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

davidpanderson
Copy link
Contributor

(should do this uniformly in user-facing web pages)

(should do this uniformly in user-facing web pages)
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #5206 (9574ae9) into master (6b41af0) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5206   +/-   ##
=========================================
  Coverage     10.86%   10.87%           
  Complexity     1064     1064           
=========================================
  Files           279      279           
  Lines         35980    35977    -3     
  Branches       8257     8255    -2     
=========================================
  Hits           3911     3911           
+ Misses        31677    31674    -3     
  Partials        392      392           

see 1 file with indirect coverage changes

@AenBleidd
Copy link
Member

AenBleidd commented Apr 22, 2023

@davidpanderson, do we call in this case Android devices as computers as well? Technically this is not correct while still quite understandable

@davidpanderson
Copy link
Contributor Author

The choices are "device" and "computer".
A while back we chose "computer" because it's more accurate.
Smartphones are computers too.

@AenBleidd AenBleidd merged commit 2d7e82b into master Apr 22, 2023
@AenBleidd AenBleidd deleted the dpa_venue branch August 15, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants