Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: window title not updated in some cases #123

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: window title not updated in some cases #123

merged 1 commit into from
Jul 30, 2024

Conversation

BLumia
Copy link
Owner

@BLumia BLumia commented Jul 30, 2024

cc @yyc12345

变更内容:

  1. 把拖拽文件的事件处理从 graphicsview 挪出来到 mainwindow 了,这样 graphicsview 不需要关心到底需不需要更新 playlist(本来也不该关心,之前的写法sb)
  2. 确保 modelreset 的时候也会试图更新标题,避免切换播放列表时,整个播放列表更新了但当前项下标不变导致不会触发当前项更新信号,使得标题不会更新的问题
  3. 给了 m_currentIndex 一个默认值,这样首次一定会触发下标变化信号。
  4. 将切换图片的逻辑从 galleryCurrent 挪到 galleryPrevgalleryNext 里,避免相同的图片被加载多次。

Copy link
Contributor

@yyc12345 yyc12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this is all I can review.
My remix version doesn't involve these code, so I can't give any advice about whether these modifications are correct.

app/mainwindow.cpp Outdated Show resolved Hide resolved
@BLumia BLumia merged commit 3596f9e into master Jul 30, 2024
14 checks passed
@BLumia BLumia deleted the window-title branch July 30, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants