Add overflow-visible prop #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-ssr-carousel ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
weotch
commented
Aug 31, 2022
Comment on lines
+38
to
+39
| # Disable the overflow:hidden on the mask | ||
| overflowVisible: Boolean |
There was a problem hiding this comment.
@brokenhd this is the new prop I'm adding for handling the stuff we looked at today without having to override internal CSS.
There was a problem hiding this comment.
@brokenhd what do you think of the name? I also considered no-mask...
There was a problem hiding this comment.
Eh, gonna stick with overflow-visible
Comment on lines
+167
to
+169
| ## Supply your own overflow:hidden | ||
|
|
||
| Add the `overflow-visible` prop to supply your own `overflow: hidden`, for cases where you want to prevent the width of the carousel from expanding but do want the carousel to extend to the edges of the page. It makes the most sense with a big `peek-right` that hints at other slides. |
There was a problem hiding this comment.
@brokenhd I added a demo of the approach we came up with today here: https://deploy-preview-87--vue-ssr-carousel.netlify.app/peeking, because I bet we'll be applying this on other projects as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83.