-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add looping #33
Merged
Merged
Add looping #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #29. Also fixes issue where clicking on an arrow triggered the `mousedown` event on the mask
✔️ Deploy Preview for vue-ssr-carousel ready! 🔨 Explore the source changes: 9ac74d3 🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-ssr-carousel/deploys/6214675bf855e90008bc3de3 😎 Browse the preview: https://deploy-preview-33--vue-ssr-carousel.netlify.app |
weotch
commented
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if current approach needs to recursively clone children, some of the examples I found depended on thatSeems to be fine w/oindex
4 would begin with slide 2 and everything gets more wonky from there.I think this is a better solution than, say, making page 3 a sort of half page ... that feels less loop-y to me.Could thessr-carousel-slide
add this ... like addmargin-right
equal to whatever is needed? And only when@loop
?Update the docs to call out this behaviorCloses #10, #29