Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for v-model with loop #111

Merged
merged 5 commits into from
Nov 8, 2022
Merged

Fix for v-model with loop #111

merged 5 commits into from
Nov 8, 2022

Conversation

weotch
Copy link
Member

@weotch weotch commented Nov 8, 2022

When dragging past the last page there were weird side effects

I’m counting on the calculation to being *that* heavy and it makes it so there isn’t a weird tweening when resizing the browser window.  Also lets us lose lodash dependency.
It doesn’t seem to be necessary anymore in my local testing and it was casuing problems for the first index change
Also, add smarter logic for deciding when to re-emit the input
@codesandbox
Copy link

codesandbox bot commented Nov 8, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 8, 2022

Deploy Preview for vue-ssr-carousel ready!

Name Link
🔨 Latest commit c63b2b3
🔍 Latest deploy log https://app.netlify.com/sites/vue-ssr-carousel/deploys/6369c13826c81800084ac377
😎 Deploy Preview https://deploy-preview-111--vue-ssr-carousel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Nov 8, 2022



Test summary

18 0 0 0


Run details

Project vue-ssr-carousel
Status Passed
Commit c63b2b3
Started Nov 8, 2022 2:39 AM
Ended Nov 8, 2022 2:41 AM
Duration 02:34 💡
OS Linux Ubuntu - 20.04
Browser Electron 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@weotch weotch merged commit 82647f8 into main Nov 8, 2022
@weotch weotch deleted the v-model-loop-fix branch November 8, 2022 02:42
@weotch weotch mentioned this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant