Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for functional components in slides with SSG #78

Closed
weotch opened this issue Aug 19, 2022 · 1 comment
Closed

Add support for functional components in slides with SSG #78

weotch opened this issue Aug 19, 2022 · 1 comment

Comments

@weotch
Copy link
Member

weotch commented Aug 19, 2022 •
edited
Loading

craft-visual instances won't render during SSG. Direct visual instances, like in our looping demo, do. I figure the issue is that they're functional.
@weotch
Copy link
Member Author

weotch commented Aug 19, 2022 •
edited
Loading

The prob wasn't functional components specifically but ones that referenced components registered as strings for use with @nuxt/components. Like this:

https://github.com/BKWLD/cloak-visual/blob/0c4456ff1aecf69e8d6f07398cbc4b6dea0d228f/adapters/globals/craft-visual.coffee#L27

weotch added a commit that referenced this issue Aug 19, 2022
@weotch
Emit an error message when no data property found on vnode
755a17b 
#78
@weotch weotch closed this as completed Aug 19, 2022
weotch added a commit to BKWLD/cloak-visual that referenced this issue Aug 19, 2022
@weotch
Explicitly use components from functional global components
7cde7da 
See BKWLD/vue-ssr-carousel#78
@weotch weotch mentioned this issue Aug 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weotch