Laravel 5 service provider with backwards compatibility #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
closed this
ghost
reopened this
|
Yeah, maybe a convention will arise in the future for env configs in packages, but your approach works for me and is nicely backwards compatible too. |
weotch
added a commit
that referenced
this pull request
Feb 12, 2015
Laravel 5 service provider with backwards compatibility
|
Well this could be useful http://laravel.io/forum/01-16-2015-laravel-5-package-configuration. Also could you do a new release please. |
|
Done, thanks for the contribution! |
|
@weotch Am still having the same Laravel 5.2 compatibility error, tried BTW, thanks for the cool package :) |
|
I just tagged a 4.4.0 relaease which contains the fix for #119 which I think will fix your issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not fully tested yet, but the provider loads and the Facade works, unless there's any code other than the service providers, should be all good