-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with pulling from links fixed #1486
Issues with pulling from links fixed #1486
Conversation
@BHoMBot check versioning |
@pawelbaran to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies @enarhi, I forgot to mention that the mirrored links require BHoM/BHoM_Engine#3356 to be built locally - updated the PR description now. Meanwhile, I think we can tell the tests went positive on your end, the only issue originating from the missing information about the need to build a specific BHoM_Engine branch. Thanks! |
@BHoMBot check versioning |
@pawelbaran to confirm, the following actions are now queued:
There are 38 requests in the queue ahead of you. |
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 50 requests in the queue ahead of you. |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests passed, happy to approve 👍
@BHoMBot check installer |
@pawelbaran to confirm, the following actions are now queued:
|
@pawelbaran to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #1477
Test files
This is quite a substantial change to the adapter mechanics, so thorough testing is required. Following tests to be done:
Changelog
Additional comments