Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks and additions to the code base #1419

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

A mashup of a few minor tweaks and additions that accumulated on my machine while working on different bits:

  • Query method for elements tagged by a given tag
  • consolidation of ToSolid internal convert
  • method to get bounds of a group of Revit points (mirror of a Geometry_Engine method added to avoid converts to BHoM and back, performance reasons)

Test files

Changelog

Additional comments

@pawelbaran pawelbaran added the type:feature New capability or enhancement label Nov 20, 2023
@pawelbaran pawelbaran self-assigned this Nov 20, 2023
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Nov 20, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 20, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 39 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Nov 20, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 20, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@michal-pekacki michal-pekacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, happy to approve 👍

@michal-pekacki
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 21, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 44062e2 into develop Nov 21, 2023
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the ModelManagement_Tool-#27-ElementTagStatus branch November 21, 2023 10:53
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants