Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bars arent created after pushing surfaces #178

Conversation

Arne-Martensen
Copy link
Contributor

Issues addressed by this PR

When first pushing Panels and Bars initially the Bars were not pushed.
After merging this changes this problem should have been fixed.

Closes #176

Test files

Test File

Changelog

  • Manipulated the order in which Panels and Bars are written using the dependencies in the RFEM6 adapter

@Arne-Martensen Arne-Martensen added the type:bug Error or unexpected behaviour label Sep 20, 2023
Copy link
Contributor

@staintono staintono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the provided test script, bars can now be pushed at the same time as surfaces. The code was not reviewed.

@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 20, 2023

@Arne-Martensen to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 20, 2023

@Arne-Martensen to confirm, the following actions are now queued:

  • check versioning

@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 20, 2023

@Arne-Martensen to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 20, 2023

@Arne-Martensen to confirm, the following actions are now queued:

  • check installer

There are 11 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 20, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit f7ea9e6 into develop Sep 20, 2023
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the RFEM5_Toolkit-#176-BarsArentCreateAfterPushingsurfaces branch September 20, 2023 18:47
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bars arent created after pushing surfaces
3 participants