-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed VirtualEnvironmentExists #128
Fixed VirtualEnvironmentExists #128
Conversation
@Tom-Kingstone to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on discussion with @jamesramsden-bh and @Tom-Kingstone , this is not the right place to add the protection - it needs adding in the Version
method as well.
… executable that doesn't exist
@Tom-Kingstone to confirm, the following actions are now queued:
|
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks robust now on code review @Tom-Kingstone , thanks!
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #127
Added a check for if the executable it is trying to run actually exists before running.
Test files
run LBT environment installer in grasshopper.
Changelog
Additional comments