Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handling of no cases provided for ResultRequest. #378

Conversation

KalleEdstroem
Copy link
Contributor

@KalleEdstroem KalleEdstroem commented Nov 20, 2023

Fix bug for no results when no load cases is specified.

Issues addressed by this PR

Closes #373

When no loadcases is specified no result was returned without a description or warning for why. This PR sees to fix this bug by providing the results from all loadcases when no specific cases is specified.

This is in line with descriptions in the ...ResultRequest method in the Structure_oM
https://github.com/BHoM/BHoM/blob/7a13095ab3de961715b4a6c8c18b60771e624f2f/Structure_oM/Requests/BarResultRequest.cs#L43-L46

Test files

Grasshopper script, lusas .mdl file , and related lusas files provided below.
Download all files to the same location and run the script and lusas as usual.

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/Lusas_Toolkit/%23373%20Misleading%20hint%20in%20ResultRequest%20component?csf=1&web=1&e=BRp3ut

Changelog

  • Fixed bug whereby if users did not provide any LoadcaseIds, no results were returned. Now if no LoadcaseIds are provided, all LoadcaseIds will be used to return results (of all types)

Additional comments

@KalleEdstroem KalleEdstroem added size:S Measured in minutes type:bug Error or unexpected behaviour labels Nov 20, 2023
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the script and works as intended. Given it's implemented in the GetLoadcaseIds method it will be utilised for all result calls.

@peterjamesnugent
Copy link
Member

@BHoMBot check required
@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 20, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check copyright-compliance
  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 9cb231e into develop Nov 20, 2023
10 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Lusas_Toolkit-#373-FixBugForMisleadingHintInResultRequest branch November 20, 2023 22:48
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S Measured in minutes type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading hint in ResultRequest component
3 participants