Added handling of no cases provided for ResultRequest. #378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug for no results when no load cases is specified.
Issues addressed by this PR
Closes #373
When no
loadcases
is specified no result was returned without a description or warning for why. This PR sees to fix this bug by providing the results from all loadcases when no specificcases
is specified.This is in line with descriptions in the
...ResultRequest
method in theStructure_oM
https://github.com/BHoM/BHoM/blob/7a13095ab3de961715b4a6c8c18b60771e624f2f/Structure_oM/Requests/BarResultRequest.cs#L43-L46
Test files
Grasshopper script, lusas .mdl file , and related lusas files provided below.
Download all files to the same location and run the script and lusas as usual.
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/Lusas_Toolkit/%23373%20Misleading%20hint%20in%20ResultRequest%20component?csf=1&web=1&e=BRp3ut
Changelog
Additional comments