-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed several bugs and simplified non-critical objects #158
Fixed several bugs and simplified non-critical objects #158
Conversation
…into LadybugTools_Toolkit-#154_#156-MinorBugFixes
@BHoMBot check compliance |
@tg359 to confirm, the following actions are now queued:
|
@BHoMBot check core |
@tg359 to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
@BHoMBot check versioning |
@tg359 to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
@BHoMBot check null-handling |
@tg359 to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@tg359 to confirm, the following actions are now queued:
|
@BHoMBot check serialisation |
@tg359 to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a quick code review, and test in jupyter, the bugs set out in the issues are fixed. I've got a comment for future reference, but am happy for this to be merged as it is now
LadybugTools_Engine/Python/src/ladybugtools_toolkit/plot/_evaporative_cooling_potential.py
Show resolved
Hide resolved
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is installer. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 19445745530 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #154
Closes #155
Closes #156
Closes #157
Test files
Changelog
Additional comments