Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed several bugs and simplified non-critical objects #158

Merged

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Dec 5, 2023

Issues addressed by this PR

Closes #154
Closes #155
Closes #156
Closes #157

Test files

Changelog

Additional comments

@tg359 tg359 added severity:low Doesn't stop/slow current workflow size:S Measured in minutes labels Dec 5, 2023
@tg359 tg359 self-assigned this Dec 5, 2023
@tg359
Copy link
Contributor Author

tg359 commented Dec 6, 2023

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Dec 6, 2023

@tg359 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@tg359
Copy link
Contributor Author

tg359 commented Dec 6, 2023

@BHoMBot check core

Copy link

bhombot-ci bot commented Dec 6, 2023

@tg359 to confirm, the following actions are now queued:

  • check core

There are 7 requests in the queue ahead of you.

@tg359
Copy link
Contributor Author

tg359 commented Dec 6, 2023

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Dec 6, 2023

@tg359 to confirm, the following actions are now queued:

  • check versioning

There are 9 requests in the queue ahead of you.

@tg359
Copy link
Contributor Author

tg359 commented Dec 6, 2023

@BHoMBot check null-handling

Copy link

bhombot-ci bot commented Dec 6, 2023

@tg359 to confirm, the following actions are now queued:

  • check null-handling

@tg359
Copy link
Contributor Author

tg359 commented Dec 6, 2023

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Dec 6, 2023

@tg359 to confirm, the following actions are now queued:

  • check unit-tests

@tg359
Copy link
Contributor Author

tg359 commented Dec 6, 2023

@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Dec 6, 2023

@tg359 to confirm, the following actions are now queued:

  • check serialisation

There are 1 requests in the queue ahead of you.

Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a quick code review, and test in jupyter, the bugs set out in the issues are fixed. I've got a comment for future reference, but am happy for this to be merged as it is now

@Tom-Kingstone Tom-Kingstone added the type:bug Error or unexpected behaviour label Dec 8, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

Copy link

bhombot-ci bot commented Dec 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Dec 8, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link

bhombot-ci bot commented Dec 8, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is installer.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 19445745530

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 19445745530

Copy link

bhombot-ci bot commented Dec 8, 2023

@FraserGreenroyd I have now provided a passing check on reference 19445745530 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Dec 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 5999708 into develop Dec 8, 2023
12 of 13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the LadybugTools_Toolkit-#154_#156-MinorBugFixes branch December 8, 2023 11:09
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:low Doesn't stop/slow current workflow size:S Measured in minutes type:bug Error or unexpected behaviour
Projects
None yet
3 participants