-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapter methods: Serialisation to and from ladybug objects #142
Adapter methods: Serialisation to and from ladybug objects #142
Conversation
…t methods to make public objects easier to understand
…t methods to make public objects easier to understand
…ps://github.com/BHoM/LadybugTools_Toolkit into LadybugTools_Toolkit-#136-SerialisationRefactor
…arp?), and updated Read to use the new method
… Convert methods, and updated the description on the LBT adapter
… the keys so that they reflect what is expected python-side
…om ILadybugTools interface.
…, and did a small refactor of the current oM objects (I fear the versioning for this PR greatly)
… end quotes on first and last items
…ames to better reflect what the objects are used for
…override Name on objects that inherit BHoMObject)
The check |
The check |
The check |
The check |
@Tom-Kingstone to confirm, the following actions are now queued:
|
The check |
The check |
The check |
LadybugTools_Adapter/Convert/Constructions/EnergyMaterialVegetation.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @Tom-Kingstone nice to get this over the line and deployed for alpha testing with the users
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
The check |
The check |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #136
Added the LadybugTools Adapter, with Pull and Push actions, that both use a
LadybugConfig
action config with aFileSettings
property for a json file.Pull:
This reads the contents of the json file, uses the BHoM serialiser to convert it into a dictionary (or custom object, depending on the layout of the json), checks against the
"type"
key in the dictionary and tries to convert the deserialised dictionary into aLadybugTools
object of that type.Push:
This takes in a
LadybugTools
object, and tries to convert it into a json serialised dictionary that can be read and deserialised into a ladybug readable python dictionary.There were also some changes made to objects in the oM that might need handling in
versioning_70.json
and the versioning toolkit.Test files
LBT_Tests.zip
Run this script using the serialised objects here:
Serialised objects.zip
Changelog
Additional comments