Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional Pollination version check #133

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Nov 13, 2023

Issues addressed by this PR

Closes #129

Ensures that expected version of Pollination is installed prior to running any install/Python-powered process.

Test files

(any GH script that uses InstallPythonEnv_LBT

Changelog

Additional comments

@tg359 tg359 self-assigned this Nov 13, 2023
@tg359 tg359 added severity:low Doesn't stop/slow current workflow size:XS Measured in seconds labels Nov 13, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, thanks @tg359 😄

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Nov 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check core

Copy link

bhombot-ci bot commented Nov 14, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 14, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Nov 14, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 14, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 14, 2023

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Nov 14, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Nov 14, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 4125cd6 into develop Nov 14, 2023
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the LBT_Tk-#129-PollinationVersionCheck branch November 14, 2023 10:31
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:low Doesn't stop/slow current workflow size:XS Measured in seconds type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Pollination is installed to correct version
3 participants