Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests for pushing panels #238

Merged
merged 11 commits into from
Oct 25, 2023

Conversation

Tom-Kingstone
Copy link
Contributor

Issues addressed by this PR

Closes #236

Functional tests for the the push functionality have been created that test the following:

  • Pushing panels to GEM with 3D shades. Tests if the panels as they are in the json file are identical to the ones pushed and pulled, and checks that the correct number of spaces were created.
  • Pushing panels to GEM with 2D shades with openings. Tests as above.

Test files

Changelog

Additional comments

JSON files created in #237 used to push to a temporary file for testing.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

.ci/unit-tests/IES_Adapter_Test/IES_Adapter_Test.csproj Outdated Show resolved Hide resolved
.ci/unit-tests/IES_Adapter_Test/PushTests.cs Show resolved Hide resolved
.ci/unit-tests/IES_Adapter_Test/PushTests.cs Show resolved Hide resolved
.ci/unit-tests/IES_Adapter_Test/PushTests.cs Show resolved Hide resolved
.ci/unit-tests/IES_Adapter_Test/PushTests.cs Outdated Show resolved Hide resolved
.ci/unit-tests/IES_Adapter_Test/PushTests.cs Outdated Show resolved Hide resolved
.ci/unit-tests/IES_Adapter_Test/PushTests.cs Outdated Show resolved Hide resolved
.ci/unit-tests/IES_Adapter_Test/PushTests.cs Outdated Show resolved Hide resolved
Co-authored-by: Fraser Greenroyd <[email protected]>
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks @Tom-Kingstone

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, installer, null-handling, ready-to-merge, serialisation, versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit a82146a into develop Oct 25, 2023
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the IES_Toolkit-#236-NUnitTestsPush branch October 25, 2023 11:32
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:test-script Creation of unit test required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NUnit test for pushing data to GEM files
2 participants