Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shades not pulling openings #233

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #232

shade openings now pull properly when ShadesAs3D is set to false.

Test files

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:bug Error or unexpected behaviour label Oct 20, 2023
@Tom-Kingstone Tom-Kingstone self-assigned this Oct 20, 2023
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 20, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 20, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 20, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 20, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 20, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

@charliebrookerBH charliebrookerBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in peer programming session and also demonstrated in IES.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 20, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on debugging through this @Tom-Kingstone and finding the line of code @kprusicka and I commented out and forgot to put back in once we resolved the openings earlier this year!

I'm going to raise an issue to remove the commented line for L140 but will merge this PR as it resolves the issue described. Approved on code review.

@FraserGreenroyd FraserGreenroyd changed the title fixed shades not pulling openings Fix shades not pulling openings Oct 23, 2023
@FraserGreenroyd FraserGreenroyd merged commit 82838e6 into develop Oct 23, 2023
@FraserGreenroyd FraserGreenroyd deleted the IES_Toolkit-#232-PullShadeOpenings branch October 23, 2023 08:14
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pulling 2D shades does not pull openings that are part of the shade
3 participants