-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shades not pulling openings #233
Conversation
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@Tom-Kingstone to confirm, the following actions are now queued:
|
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed in peer programming session and also demonstrated in IES.
@BHoMBot check ready-to-merge |
@Tom-Kingstone to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on debugging through this @Tom-Kingstone and finding the line of code @kprusicka and I commented out and forgot to put back in once we resolved the openings earlier this year!
I'm going to raise an issue to remove the commented line for L140 but will merge this PR as it resolves the issue described. Approved on code review.
NOTE: Depends on
Issues addressed by this PR
Closes #232
shade openings now pull properly when ShadesAs3D is set to false.
Test files
Changelog
Additional comments