Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM_Engine: Replaced C:\ProgramData with SpecialFolder construct #3221

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

albinber
Copy link
Contributor

…clude the new method instead

NOTE: Depends on

Issues addressed by this PR

Closes #3219

Replaced C:\ProgramData with methods using SpecialFolder construct.

Test files

Changelog

Additional comments

@albinber albinber added the type:feature New capability or enhancement label Nov 28, 2023
@albinber albinber self-assigned this Nov 28, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the /***************************************************/ between each method to break them up 😄

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @albinber , this will help with our migration from a fixed C: to a location anyone can use 😄

Can you add descriptions to all the methods for documentation purposes. For example, for the Upgrades method, it would be useful to state something like Returns the folder path for the top level upgrades directory, which houses sub-directories for upgraders for different BHoM versions to make it clear to users and developers that it only links to the top-level and nothing else (so they'll need to Path.Combine to get into sub-directories/folders) 😄

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run through in Grasshopper checking the output is correct for my machine and it all looks good, good work @albinber 😄

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Nov 28, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 28, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Nov 28, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit f182b02 into develop Nov 28, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#3219-MethodForBHoMFolders branch November 28, 2023 18:48
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BHoM_Engine: Methods for returning BHoM folders
2 participants