-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHoM_Engine: Replaced C:\ProgramData with SpecialFolder construct #3221
BHoM_Engine: Replaced C:\ProgramData with SpecialFolder construct #3221
Conversation
…clude the new method instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the /***************************************************/
between each method to break them up 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @albinber , this will help with our migration from a fixed C:
to a location anyone can use 😄
Can you add descriptions to all the methods for documentation purposes. For example, for the Upgrades
method, it would be useful to state something like Returns the folder path for the top level upgrades directory, which houses sub-directories for upgraders for different BHoM versions
to make it clear to users and developers that it only links to the top-level and nothing else (so they'll need to Path.Combine
to get into sub-directories/folders) 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've run through in Grasshopper checking the output is correct for my machine and it all looks good, good work @albinber 😄
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
…clude the new method instead
NOTE: Depends on
Issues addressed by this PR
Closes #3219
Replaced C:\ProgramData with methods using SpecialFolder construct.
Test files
Changelog
Additional comments