Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security_Engine: Fixed documentation compliance #3217

Merged

Conversation

albinber
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #3167

Added input description to make it compliant.

Test files

Changelog

Additional comments

@albinber albinber added the type:documentation Wiki, help or in code attributes label Nov 27, 2023
@albinber albinber self-assigned this Nov 27, 2023
@albinber
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Nov 27, 2023

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 25 requests in the queue ahead of you.

@albinber
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 27, 2023

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 1 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Nov 27, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 27, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @albinber

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Nov 27, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 2cb872d into develop Nov 27, 2023
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Security_Engine-#3167-FixDocumentationCompliance branch November 27, 2023 14:12
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Wiki, help or in code attributes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security_Engine: Fix documentation compliance
2 participants