-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ground_Engine: Add associated engine methods for boreholes, stratum and chemical data #3189
Conversation
…d add IsNull method for Borehole
…rehole Create method
…(the properties have default values and are optional anyway)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions on the Create
and IsNull
methods:
No comments from Michael (GE) based on offline discussion on Engine methods. |
@peterjamesnugent to confirm, the following actions are now queued:
There are 5 requests in the queue ahead of you. |
@BHoMBot check documentation-compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check documentation-compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I can't speak for the functionality on the user side, I am happy with the code itself
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 17 requests in the queue ahead of you. |
The check |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@peterjamesnugent just to let you know, I have provided a |
@peterjamesnugent just to let you know, I have provided a |
FAO: @FraserGreenroyd The check they wish to have dispensation on is installer. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 19422247696 |
@FraserGreenroyd I have now provided a passing check on reference |
@peterjamesnugent just to let you know, I have provided a |
NOTE: Depends on
BHoM/BHoM#1560
Issues addressed by this PR
Closes #3175
Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/AGS_Toolkit/%231-AddInitialFunctionality.gh?csf=1&web=1&e=UxKkOS
Changelog
Create
methods andIsValid
methods forBorehole
,Stratum
andContaminantSample
objectsQuery
method to retrieveStratum
lines that are useful for visualisationAdditional comments