Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ground_Engine: Add associated engine methods for boreholes, stratum and chemical data #3189

Merged
merged 20 commits into from
Dec 7, 2023

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Sep 27, 2023

NOTE: Depends on

BHoM/BHoM#1560

Issues addressed by this PR

Closes #3175

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/AGS_Toolkit/%231-AddInitialFunctionality.gh?csf=1&web=1&e=UxKkOS

Changelog

  • Added Create methods and IsValid methods for Borehole, Stratum and ContaminantSample objects
  • Added Query method to retrieve Stratum lines that are useful for visualisation

Additional comments

@peterjamesnugent peterjamesnugent added type:feature New capability or enhancement status:WIP PR in progress and still in draft, not ready for formal review labels Sep 27, 2023
@peterjamesnugent peterjamesnugent self-assigned this Sep 27, 2023
@peterjamesnugent peterjamesnugent changed the title Ground_Engine: Ground_Engine: Add associated engine methods for boreholes, stratum and chemical data Oct 31, 2023
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions on the Create and IsNull methods:

@peterjamesnugent
Copy link
Member Author

No comments from Michael (GE) based on offline discussion on Engine methods.

@peterjamesnugent peterjamesnugent removed the status:WIP PR in progress and still in draft, not ready for formal review label Dec 7, 2023
@peterjamesnugent
Copy link
Member Author

@BHoMBot check code-compliance
@BHoMBot check copyright-compliance
@BHoMBot check documentation-compliance
@BHoMBot check project-compliance

Copy link

bhombot-ci bot commented Dec 7, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check copyright-compliance
  • check documentation-compliance
  • check project-compliance

There are 5 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check documentation-compliance

Copy link

bhombot-ci bot commented Dec 7, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check documentation-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check documentation-compliance

Copy link

bhombot-ci bot commented Dec 7, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check documentation-compliance

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I can't speak for the functionality on the user side, I am happy with the code itself

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Dec 7, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 17 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Dec 7, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Dec 7, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 19 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Dec 7, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link

bhombot-ci bot commented Dec 7, 2023

@peterjamesnugent just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

Copy link

bhombot-ci bot commented Dec 7, 2023

@peterjamesnugent just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

Copy link

bhombot-ci bot commented Dec 7, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is installer.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 19422247696

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 19422247696

Copy link

bhombot-ci bot commented Dec 7, 2023

@FraserGreenroyd I have now provided a passing check on reference 19422247696 as requested.

Copy link

bhombot-ci bot commented Dec 7, 2023

@peterjamesnugent just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit b70bc2b into develop Dec 7, 2023
@FraserGreenroyd FraserGreenroyd deleted the Ground_oM-#1551-AddNewGroundObjects branch December 7, 2023 18:34
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ground_Engine: Add associated methods for Borehole and Geology objects
3 participants