-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some voice lines share the same IDs, causing them to toggle each other #3087
Comments
I had a similar issue way back in BEEmod/BEE2.4#328. It might be a good idea to make the app produce a warning if there are multiple things like this with the same ID, to prevent stuff like this from happening in the future. |
@Luke18033 |
In most other places duplicates do raise an error, I need to do that for these. |
This breaks turning them on/off. See BEEmod/BEE2-items#3087.
I see the issue was marked as "Fixed" almost a week ago. Well, I guess I'll close it until we need it again. |
The issue will close when the update with the fix is released |
@Konclan Oh sorry for the inconvenience then. Didn't know that was required. |
I've had some problems in the past where some voice lines would be checked/unchecked if another, completely separate voice line was too.
The best example, which I've managed to fix, was the two bottom voices for GLaDOS (Clean) on Entry. These are the "Nobel Prize Winner" and the "Found A Subject" voices. If you uncheck either, the other one will be unchecked next time you open the dialog, and vice versa.
As I said before, I managed to fix this. Inside the "clean_style.zip" package, in the folder "voice" there's a configuration file, in which, the voice lines mentioned above have the same ID of "GENERIC_NOBEL_PRIZE". Changing the latter to "GENERIC_FOUND_SUBJECT" seemed to work for me. The Announcer also had some lines 'stuck' together but I cannot remember which, and I don't know if there's any other characters that have this same problem.
Overall, I think this originated from a copy-and-paste type of issue and simply no-one noticed. Can't blame anyone for it. Anyway thanks in advance.
The text was updated successfully, but these errors were encountered: