Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some voice lines share the same IDs, causing them to toggle each other #3087

Closed
pompousspaniard opened this issue Aug 22, 2019 · 6 comments · Fixed by BEEmod/BEE2.4#1209
Closed
Labels
Bug Something isn't working correctly

Comments

@pompousspaniard
Copy link

I've had some problems in the past where some voice lines would be checked/unchecked if another, completely separate voice line was too.

The best example, which I've managed to fix, was the two bottom voices for GLaDOS (Clean) on Entry. These are the "Nobel Prize Winner" and the "Found A Subject" voices. If you uncheck either, the other one will be unchecked next time you open the dialog, and vice versa.

As I said before, I managed to fix this. Inside the "clean_style.zip" package, in the folder "voice" there's a configuration file, in which, the voice lines mentioned above have the same ID of "GENERIC_NOBEL_PRIZE". Changing the latter to "GENERIC_FOUND_SUBJECT" seemed to work for me. The Announcer also had some lines 'stuck' together but I cannot remember which, and I don't know if there's any other characters that have this same problem.

Overall, I think this originated from a copy-and-paste type of issue and simply no-one noticed. Can't blame anyone for it. Anyway thanks in advance.

@vrad-exe
Copy link
Member

I had a similar issue way back in BEEmod/BEE2.4#328. It might be a good idea to make the app produce a warning if there are multiple things like this with the same ID, to prevent stuff like this from happening in the future.

@pompousspaniard
Copy link
Author

@Luke18033
I think it would be a great idea, however, I think the warning shouldn't prevent you from using the app itself. I prefer to have some options or voice lines stuck together than not being able to use BEEmod until the following release.

@TeamSpen210 TeamSpen210 added the Bug Something isn't working correctly label Aug 23, 2019
@TeamSpen210
Copy link
Member

In most other places duplicates do raise an error, I need to do that for these.

@vrad-exe vrad-exe changed the title Certain voice lines are 'stuck' together. Some voice lines share the same IDs, causing them to toggle each other Aug 23, 2019
TeamSpen210 added a commit to BEEmod/BEE2.4 that referenced this issue Aug 29, 2019
@TeamSpen210 TeamSpen210 added the Done in next release This has been addressed in the next release label Aug 30, 2019
@pompousspaniard
Copy link
Author

I see the issue was marked as "Fixed" almost a week ago. Well, I guess I'll close it until we need it again.

@Konclan
Copy link
Collaborator

Konclan commented Sep 4, 2019

The issue will close when the update with the fix is released

@pompousspaniard
Copy link
Author

@Konclan Oh sorry for the inconvenience then. Didn't know that was required.

@TeamSpen210 TeamSpen210 removed the Done in next release This has been addressed in the next release label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants