Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bd opp #76

Merged
merged 11 commits into from
Jun 23, 2020
Merged

Bd opp #76

merged 11 commits into from
Jun 23, 2020

Conversation

BDonnot
Copy link
Owner

@BDonnot BDonnot commented Jun 23, 2020

  • finishing opponent feature in make
  • rationalize the env part and its construction from the get_kwargs() method
  • add the __geattr__ method to the BaseMultiProcess env

Tezirg
Tezirg approved these changes Jun 23, 2020
View reviewed changes
Copy link

@Tezirg Tezirg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could simply RandomlineOpponent.init but its really a minor improvement

grid2op/Opponent/RandomLineOpponent.py Outdated Show resolved Hide resolved
@BDonnot BDonnot merged commit 85fc046 into opp-dev Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tezirg Tezirg Tezirg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BDonnot @Tezirg