forked from Grid2op/grid2op
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge recent developments #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…euse, and to be independant of grid2op version [skip ci]
BDonnot
commented
Jan 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including:
did things like
from grid2op.Chronics.ChangeNothing import ChangeNothing
you need to change it likefrom grid2op.Chronics.changeNothing import ChangeNothing
or even better, and this is the preferred way to includethem:
from grid2op.Chronics import ChangeNothing
. It should not affect lots of code (more refactoring of the kindare to be expected in following versions).
are to be expected in following versions).
for a given environment
Parameters
class, to limit the number of possible calls toobs.simulate(...)
see
param.MAX_SIMULATE_PER_STEP
andparam.MAX_SIMULATE_PER_EPISODE
(see issue Count the number of use of "simulate" per step and globally Grid2op/grid2op#273)delta_time
in the observation that tells the time (in minutes) between two consecutive steps.(see Create a "get back to meshed topology" Grid2op/grid2op#275)
env.action_space.get_back_to_ref_state(obs)
act.as_serializable_dict()
DiscreteActSpace
from a given list of actions (see Discrete gym act space with given list of actions Grid2op/grid2op#277)Grid2OpException
instead ofRuntimeError