Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final fix before 1.5.0 let's see if tests pass #131

Merged
merged 24 commits into from
Mar 31, 2021
Merged

Final fix before 1.5.0 let's see if tests pass #131

merged 24 commits into from
Mar 31, 2021

Conversation

BDonnot
Copy link
Owner

@BDonnot BDonnot commented Mar 31, 2021

No description provided.

BDonnot added 22 commits March 23, 2021 12:14
@BDonnot
improve error message on some cases for pandapowerr
390adb2
@BDonnot
implementing the BoxActionSpace, now move to theMultiDiscrete action
4bca7da
@BDonnot
Merge branch 'master' into bd_dev
568af41
@BDonnot
trying to fix runner issue on macos
12babed
@BDonnot
need some code cleaning, but try to adress runner issue on windows / …
76243f2 
…macos
@BDonnot
still trying to make the runner working in parrallel for windows and …
6023a73 
…now macos
@BDonnot
trying to fix issue of the runner on macos / windows
3b606f7
@BDonnot
fixing test of Action and Observation too now
8656a13
@BDonnot
real fix for observation now...
5abc57c
@BDonnot
finishing the stable_baselines part of the notebook, trying tf agents…
09350ab 
… now
@BDonnot
finishing notebook for integration with RL framework
11ab78e
@BDonnot
finishing doc and tests for BoxObsSpace
c62ef9e
@BDonnot
fix typos in the doc of gymboxspace
54565ee
@BDonnot
fix a typo in the test of the gym_compat module
bb2a220
@BDonnot
fixing a bug in one example, continuing the doc for the gym.rst file
c8a5650
@BDonnot
clean the notebooks
ecbf4a9
@BDonnot
adding test for box_gymactspace
da6ba7d
@BDonnot
adding doc for gym box act space
101afe0
@BDonnot
making tests for MultiDiscreteActSpace
3c37413
@BDonnot
adding test and doc for MultiDiscrete
595daf2
@BDonnot
finishing test and docs for DiscreteGymActSpace
9561c83
@BDonnot
some modification thanks to sonarcloud
b8bd69b
BDonnot
BDonnot commented Mar 31, 2021
View reviewed changes
Copy link
Owner Author

@BDonnot BDonnot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look ok

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

BDonnot
BDonnot commented Mar 31, 2021
View reviewed changes
Copy link
Owner Author

@BDonnot BDonnot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@BDonnot BDonnot merged commit 0788032 into master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BDonnot