Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/license #24

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Fix/license #24

merged 3 commits into from
Nov 20, 2023

Conversation

marmoure
Copy link
Contributor

@marmoure marmoure commented Nov 14, 2023

Fix some minor bugs to get the CI working again

@marmoure marmoure force-pushed the fix/license branch 3 times, most recently from ebc1e65 to ca106c0 Compare November 14, 2023 20:16
Copy link
Collaborator

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes needed

pom.xml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JDialog.java to edit this template
/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look correct as it is set as Javadoc and not a comment, have you tested this via mvn clean verify using the latest license-maven-plugin version?

@@ -1,3 +1,22 @@
/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as above.

@adamretter adamretter merged commit 61299e5 into BCDH:master Nov 20, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants