Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the XIA PF4 filter support #558

Merged
merged 3 commits into from
Oct 13, 2021
Merged

update the XIA PF4 filter support #558

merged 3 commits into from
Oct 13, 2021

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added this to the 1.5.3 milestone Oct 13, 2021
@prjemian prjemian self-assigned this Oct 13, 2021
@prjemian
Copy link
Contributor Author

APS (read-only) test looks good to me:

In [1]: from apstools.devices import Pf4FilterDual

In [2]: ioc = "9idcUSX:pf4:"

In [3]: pf4 = Pf4FilterDual(ioc, name="pf4")

In [4]: pf4.connected
Out[4]: True

In [5]: pf4.read()
Out[5]:
OrderedDict([('pf4_transmission',
              {'value': 1.0, 'timestamp': 1634079142.839608}),
             ('pf4_inverse_transmission',
              {'value': 1.0, 'timestamp': 1634079142.839672})])

In [6]: pf4.summary()
data keys (* hints)
-------------------
 pf4_inverse_transmission
*pf4_transmission

read attrs
----------
transmission         EpicsSignalRO       ('pf4_transmission')
inverse_transmission EpicsSignalRO       ('pf4_inverse_transmission')
A                    Pf4FilterBank       ('pf4_A')
B                    Pf4FilterBank       ('pf4_B')

config keys
-----------
pf4_A_bits
pf4_A_control
pf4_A_fPos
pf4_A_transmission
pf4_B_bits
pf4_B_control
pf4_B_fPos
pf4_B_transmission
pf4_energy_keV_local
pf4_energy_keV_mono
pf4_mode
pf4_thickness_Al_mm
pf4_thickness_Ti_mm
pf4_thickness_glass_mm

configuration attrs
-------------------
thickness_Al_mm      EpicsSignalRO       ('pf4_thickness_Al_mm')
thickness_Ti_mm      EpicsSignalRO       ('pf4_thickness_Ti_mm')
thickness_glass_mm   EpicsSignalRO       ('pf4_thickness_glass_mm')
energy_keV_local     EpicsSignal         ('pf4_energy_keV_local')
energy_keV_mono      EpicsSignal         ('pf4_energy_keV_mono')
mode                 EpicsSignal         ('pf4_mode')
A                    Pf4FilterBank       ('pf4_A')
A.fPos               EpicsSignal         ('pf4_A_fPos')
A.control            EpicsSignalRO       ('pf4_A_control')
A.bits               EpicsSignalRO       ('pf4_A_bits')
A.transmission       EpicsSignalRO       ('pf4_A_transmission')
B                    Pf4FilterBank       ('pf4_B')
B.fPos               EpicsSignal         ('pf4_B_fPos')
B.control            EpicsSignalRO       ('pf4_B_control')
B.bits               EpicsSignalRO       ('pf4_B_bits')
B.transmission       EpicsSignalRO       ('pf4_B_transmission')

unused attrs
------------


In [7]: from apstools.utils import listdevice

In [8]: listdevice(pf4)
Out[8]:
                   data name    value                  timestamp
0           pf4_transmission      1.0 2021-10-12 17:52:22.839608
1   pf4_inverse_transmission      1.0 2021-10-12 17:52:22.839672
2        pf4_thickness_Al_mm      0.0 2021-10-12 17:52:22.838242
3        pf4_thickness_Ti_mm      0.0 2021-10-12 17:52:22.839227
4     pf4_thickness_glass_mm      0.0 1989-12-31 18:00:00.000000
5       pf4_energy_keV_local     21.0 2021-09-15 16:02:16.001024
6        pf4_energy_keV_mono     21.0 2021-09-15 16:02:16.000840
7                   pf4_mode   mono E 1989-12-31 18:00:00.000000
8                 pf4_A_fPos        0 2021-10-12 18:27:38.616205
9              pf4_A_control  enabled 2021-10-12 17:52:22.838843
10                pf4_A_bits        1 2021-10-12 17:52:22.838766
11        pf4_A_transmission      1.0 2021-10-12 17:52:22.838429
12                pf4_B_fPos        0 2021-10-12 18:27:38.616437
13             pf4_B_control  enabled 2021-10-12 17:52:22.839988
14                pf4_B_bits        1 2021-10-12 17:52:22.839955
15        pf4_B_transmission      1.0 2021-10-12 17:52:22.839527

@lgtm-com
Copy link

lgtm-com bot commented Oct 13, 2021

This pull request fixes 38 alerts when merging 547e8bd into e2847f0 - view on LGTM.com

fixed alerts:

  • 38 for Unused import

@prjemian prjemian merged commit c7091a9 into main Oct 13, 2021
@prjemian prjemian deleted the 462-pf4-filters branch October 13, 2021 01:06
prjemian added a commit that referenced this pull request Nov 27, 2021
prjemian added a commit that referenced this pull request Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XIA filter support needs to expand
1 participant