Undulator and Kohzu monochromator functionalities #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added some ophyd.Signal of useful parameters to move the undulator energy. - No clear that undulator_setup should be here. This may be a problem if one uses Jupyter.
prjemian
reviewed
Nov 14, 2020
prjemian
reviewed
Nov 14, 2020
prjemian
reviewed
Nov 14, 2020
|
Per #430, I'd like to change the default branch name from |
|
@gfabbris Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApsUndulatorAdds some
Signalcomponents that are helpful in moving the undulator (as far as I know these don't exist in the EPICS support).Interactive
.undulator_setup- this is certainly useful for 4-ID-D, not sure others would want it.KohzuSeqCtl_Monochromator.calibrate_energy.