Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT #146 modify unused variable #147

Merged
merged 5 commits into from
May 20, 2019
Merged

MNT #146 modify unused variable #147

merged 5 commits into from
May 20, 2019

Conversation

prjemian
Copy link
Contributor

fixes #146

@prjemian prjemian added this to the milestone-2019-09 milestone May 19, 2019
@prjemian prjemian self-assigned this May 19, 2019
@lgtm-com
Copy link

lgtm-com bot commented May 19, 2019

This pull request fixes 1 alert when merging 690db51 into c2d9452 - view on LGTM.com

fixed alerts:

  • 1 for First argument to super() is not enclosing class

Comment posted by LGTM.com

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2019

This pull request fixes 23 alerts when merging da14cab into c2d9452 - view on LGTM.com

fixed alerts:

  • 8 for Unused import
  • 4 for Unused local variable
  • 4 for Module is imported with 'import' and 'import from'
  • 3 for Unreachable code
  • 2 for Variable defined multiple times
  • 1 for Module is imported more than once
  • 1 for First argument to super() is not enclosing class

Comment posted by LGTM.com

@prjemian prjemian merged commit 5e3d188 into master May 20, 2019
@prjemian prjemian deleted the LGTM-review-146 branch May 20, 2019 12:19
@prjemian prjemian modified the milestones: milestone-2019-09, 1.1.6 May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@prjemian prjemian

Labels
enhancement
Projects
None yet
Milestone
1.1.6
Development

Successfully merging this pull request may close these issues.

LGTM code review recommendations
1 participant
@prjemian