Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issued with gossip network #79

Merged
merged 5 commits into from
Mar 7, 2019
Merged

Fix issued with gossip network #79

merged 5 commits into from
Mar 7, 2019

Conversation

gdiazlo
Copy link
Contributor

@gdiazlo gdiazlo commented Mar 7, 2019

  • Fix registration of QED server by adding their agent name
  • Fix retry code in publisher
  • Remove unused code
  • Use config objects

@gdiazlo gdiazlo requested review from iknite and jllucas March 7, 2019 14:39
jllucas
jllucas reviewed Mar 7, 2019
View reviewed changes
gossip/sender/sender.go
err := s.Agent.Memberlist().SendReliable(dst, msg)
if err == nil {
break
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "else" statement

jllucas
jllucas approved these changes Mar 7, 2019
View reviewed changes
Copy link

@jllucas jllucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iknite iknite merged commit 8232b61 into BBVA:master Mar 7, 2019
suizman pushed a commit to jllucas/qed that referenced this pull request Jun 4, 2019
@iknite
Merge pull request BBVA#79 from gdiazlo/qedgossip
d8ce16a 
Fix issued with gossip network

Former-commit-id: 8232b61
suizman pushed a commit that referenced this pull request Sep 30, 2019
@iknite
Merge pull request #79 from gdiazlo/qedgossip
4045a6c 
Fix issued with gossip network

Former-commit-id: 0ee0b49 [formerly 8232b61]
Former-commit-id: d8ce16a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jllucas jllucas jllucas approved these changes

@iknite iknite Awaiting requested review from iknite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdiazlo @jllucas @iknite